linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Calvin Walton <calvin.walton@kepstin.ca>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2] nfs-utils: Run rpcgen using the cpp found by configure.
Date: Wed, 06 May 2015 16:34:23 -0400	[thread overview]
Message-ID: <1430944463.32663.2.camel@kepstin.ca> (raw)
In-Reply-To: <554A785A.6090909@RedHat.com>

On Wed, 2015-05-06 at 16:23 -0400, Steve Dickson wrote:
> On 04/21/2015 01:31 PM, Calvin Walton wrote:
> > rpcgen normally runs with a hardcoded cpp path of e.g. /lib/cpp,
> > but not all Linux distributions install a cpp there.
> > 
> > Grab a trick from glibc, and run rpcgen with a cpp-path pointing at
> > a script; the script then runs the cpp specified in the CPP
> > environment variable - which we set to $CC -E with appropriate
> > options.
> > 
> > Signed-off-by: Calvin Walton <calvin.walton@kepstin.ca>
> I'm getting the following errors when I apply this patch:
> 
> test -f mount.h && rm -rf mount.h || true
> CPP='gcc -E -x c-header' /usr/bin/rpcgen -Y ../../tools/rpcgen -l -o 
> mount_clnt.c mount.x
> execvp: Permission denied
> /usr/bin/rpcgen: C preprocessor failed with exit code 1

This probably means that the script at tools/rpcgen/cpp failed to get 
the executable permission added during patch application. I'm not sure 
why this happens; the patch header includes "new file mode 100755" as 
git should be expecting.

Doing a chmod +x tools/rpcgen/cpp after applying the patch should fix 
the issue.

-- 
Calvin Walton <calvin.walton@kepstin.ca>

      reply	other threads:[~2015-05-06 20:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 17:31 [PATCH v2] nfs-utils: Run rpcgen using the cpp found by configure Calvin Walton
2015-05-06 20:23 ` Steve Dickson
2015-05-06 20:34   ` Calvin Walton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430944463.32663.2.camel@kepstin.ca \
    --to=calvin.walton@kepstin.ca \
    --cc=SteveD@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).