From: Calvin Walton <calvin.walton@kepstin.ca>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfs-utils: Substitute sbindir in systemd unit files.
Date: Wed, 06 May 2015 16:39:11 -0400 [thread overview]
Message-ID: <1430944751.32663.6.camel@kepstin.ca> (raw)
In-Reply-To: <554A7982.50604@RedHat.com>
On Wed, 2015-05-06 at 16:28 -0400, Steve Dickson wrote:
> On 04/21/2015 01:40 PM, Calvin Walton wrote:
> > The systemd unit files now include the correct full paths to the
> > executables when nfs-utils is configured with an alternate value
> > for e.g. --prefix or --sbindir
> >
> > Signed-off-by: Calvin Walton <calvin.walton@kepstin.ca>
> This kind of major change always makes me a bit nervous and
> unfortunately I'm not going to have the cycles to give
> it the testing I would like because I'm going on holiday
> all next week...
>
> I'll keep it on my TODO list because it sound like it makes
> sense... but probably will not get to it for a couple weeks.
>
> Also, would you mind breaking the patch up to show what you
> are doing to each script? It would make it a lot easier
> to review...
I sent the same patch, regenerated with the -M option to git, visible
at:
http://news.gmane.org/find-root.php?message_id=1429638223%2d13852%2d1%2dgit%2dsend%2demail%2dcalvin.walton%40kepstin.ca
This should be a bit more reviewable, because it shows the changes
made to each unit file following the file renames.
If you'd still prefer to have the patch split up, let me know.
--
Calvin Walton <calvin.walton@kepstin.ca>
next prev parent reply other threads:[~2015-05-06 20:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 17:40 [PATCH] nfs-utils: Substitute sbindir in systemd unit files Calvin Walton
2015-04-21 17:43 ` Calvin Walton
2015-07-14 14:32 ` Steve Dickson
2015-07-14 15:22 ` Calvin Walton
2015-07-14 15:36 ` Steve Dickson
2015-11-02 12:53 ` Steve Dickson
2015-11-02 13:23 ` Calvin Walton
2015-05-06 20:28 ` Steve Dickson
2015-05-06 20:39 ` Calvin Walton [this message]
2015-05-07 13:36 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430944751.32663.6.camel@kepstin.ca \
--to=calvin.walton@kepstin.ca \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).