linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peng Tao <tao.peng@primarydata.com>
To: linux-nfs@vger.kernel.org
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Christoph Hellwig <hch@infradead.org>, Zach Brown <zab@zabbo.net>,
	Darren Hart <dvhart@linux.intel.com>,
	bfields@fieldses.org, Jeff Layton <jeff.layton@primarydata.com>,
	Peng Tao <tao.peng@primarydata.com>
Subject: [PATCH RFC 09/11] nfs42: respect clone_blksize
Date: Tue, 25 Aug 2015 23:33:47 +0800	[thread overview]
Message-ID: <1440516829-116041-10-git-send-email-tao.peng@primarydata.com> (raw)
In-Reply-To: <1440516829-116041-1-git-send-email-tao.peng@primarydata.com>

draft-ietf-nfsv4-minorversion2-38.txt says:
   Both cl_src_offset and
   cl_dst_offset must be aligned to the clone block size Section 12.2.1.
   The number of bytes to be cloned must be a multiple of the clone
   block size, except in the case in which cl_src_offset plus the number
   of bytes to be cloned is equal to the source file size.

Signed-off-by: Peng Tao <tao.peng@primarydata.com>
---
 fs/nfs/nfs4file.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/fs/nfs/nfs4file.c b/fs/nfs/nfs4file.c
index c335cb0..ee8c014 100644
--- a/fs/nfs/nfs4file.c
+++ b/fs/nfs/nfs4file.c
@@ -174,12 +174,20 @@ nfs42_file_clone_range(struct file *src_file, struct file *dst_file,
 {
 	struct inode *dst_inode = file_inode(dst_file);
 	struct inode *src_inode = file_inode(src_file);
+	struct nfs_server *server = NFS_SERVER(dst_inode);
+	unsigned int bs = server->clone_blksize;
 	int ret;
 
 	/* src and dst must be different files */
 	if (src_inode == dst_inode)
 		return -EINVAL;
 
+	/* check alignment w.r.t. clone_blksize */
+	if (bs)
+		if (!IS_ALIGNED(src_off, bs) || !IS_ALIGNED(dst_off, bs) ||
+		    (!IS_ALIGNED(count, bs) && i_size_read(src_inode) != (src_off + count)))
+			return -EINVAL;
+
 	/* XXX: do we lock at all? what if server needs CB_RECALL_LAYOUT? */
 	if (dst_inode < src_inode) {
 		mutex_lock_nested(&dst_inode->i_mutex, I_MUTEX_PARENT);
-- 
1.8.3.1


  parent reply	other threads:[~2015-08-25 15:35 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25 15:33 [PATCH RFC 00/11] NFS/NFSD: add NFSv42 COPY operation support Peng Tao
2015-08-25 15:33 ` [PATCH RFC 01/11] vfs: pull btrfs clone API to vfs layer Peng Tao
2015-08-26  1:40   ` Peng Tao
2015-08-26  1:50   ` Dave Chinner
2015-08-26  1:59     ` Dave Chinner
2015-08-26  4:09   ` Darrick J. Wong
2015-08-26  8:03     ` Peng Tao
2015-08-25 15:33 ` [PATCH RFC 02/11] vfs/btrfs: add .clone_range file operation Peng Tao
2015-08-26  8:01   ` David Sterba
2015-08-26  8:31     ` Peng Tao
2015-08-26 13:00       ` David Sterba
2015-08-26 13:07         ` Christoph Hellwig
2015-08-25 15:33 ` [PATCH RFC 03/11] nfs42: decode_layoutstats does not need res parameter Peng Tao
2015-08-25 16:04   ` Anna Schumaker
2015-08-25 15:33 ` [PATCH RFC 04/11] nfs42: remove unused declaration Peng Tao
2015-08-25 16:05   ` Anna Schumaker
2015-08-25 16:08     ` Peng Tao
2015-08-25 15:33 ` [PATCH RFC 05/11] nfs42: add CLONE xdr functions Peng Tao
2015-08-25 15:33 ` [PATCH RFC 06/11] nfs42: add CLONE proc functions Peng Tao
2015-08-25 15:33 ` [PATCH RFC 07/11] nfs42: add .copy_range file operation Peng Tao
2015-08-25 15:33 ` [PATCH RFC 08/11] nfs: get clone_blksize when probing fsinfo Peng Tao
2015-08-25 15:33 ` Peng Tao [this message]
2015-08-25 15:33 ` [PATCH RFC 10/11] nfsd: Pass filehandle to nfs4_preprocess_stateid_op() Peng Tao
2015-08-25 15:33 ` [PATCH RFC 11/11] NFSD: Implement the CLONE call Peng Tao
2015-08-25 22:09   ` J. Bruce Fields
2015-08-25 22:11   ` J. Bruce Fields
2015-08-26  1:33     ` Peng Tao
2015-08-25 15:42 ` [PATCH RFC 00/11] NFS/NFSD: add NFSv42 COPY operation support Peng Tao
2015-08-25 16:01   ` Anna Schumaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440516829-116041-10-git-send-email-tao.peng@primarydata.com \
    --to=tao.peng@primarydata.com \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=dvhart@linux.intel.com \
    --cc=hch@infradead.org \
    --cc=jeff.layton@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    --cc=zab@zabbo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).