* [PATCH 01/19] SUNRPC: fix variable type
[not found] <1443103227-25612-1-git-send-email-a.hajda@samsung.com>
@ 2015-09-24 14:00 ` Andrzej Hajda
2015-09-25 20:25 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Andrzej Hajda @ 2015-09-24 14:00 UTC (permalink / raw)
To: linux-kernel
Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
J. Bruce Fields, Jeff Layton, Trond Myklebust, Anna Schumaker,
David S. Miller, linux-nfs, netdev
Due to incorrect len type bc_send_request returned always zero.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
Hi,
To avoid problems with too many mail recipients I have sent whole
patchset only to LKML. Anyway patches have no dependencies.
Regards
Andrzej
---
net/sunrpc/xprtsock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 1a85e0e..60fb002 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -2472,7 +2472,7 @@ static int bc_send_request(struct rpc_task *task)
{
struct rpc_rqst *req = task->tk_rqstp;
struct svc_xprt *xprt;
- u32 len;
+ int len;
dprintk("sending request with xid: %08x\n", ntohl(req->rq_xid));
/*
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 01/19] SUNRPC: fix variable type
2015-09-24 14:00 ` [PATCH 01/19] SUNRPC: fix variable type Andrzej Hajda
@ 2015-09-25 20:25 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2015-09-25 20:25 UTC (permalink / raw)
To: Andrzej Hajda
Cc: linux-kernel, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
Jeff Layton, Trond Myklebust, Anna Schumaker, David S. Miller,
linux-nfs, netdev
ACK. Assuming Trond gets this.--b.
On Thu, Sep 24, 2015 at 04:00:09PM +0200, Andrzej Hajda wrote:
> Due to incorrect len type bc_send_request returned always zero.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> Hi,
>
> To avoid problems with too many mail recipients I have sent whole
> patchset only to LKML. Anyway patches have no dependencies.
>
> Regards
> Andrzej
> ---
> net/sunrpc/xprtsock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
> index 1a85e0e..60fb002 100644
> --- a/net/sunrpc/xprtsock.c
> +++ b/net/sunrpc/xprtsock.c
> @@ -2472,7 +2472,7 @@ static int bc_send_request(struct rpc_task *task)
> {
> struct rpc_rqst *req = task->tk_rqstp;
> struct svc_xprt *xprt;
> - u32 len;
> + int len;
>
> dprintk("sending request with xid: %08x\n", ntohl(req->rq_xid));
> /*
> --
> 1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-25 20:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1443103227-25612-1-git-send-email-a.hajda@samsung.com>
2015-09-24 14:00 ` [PATCH 01/19] SUNRPC: fix variable type Andrzej Hajda
2015-09-25 20:25 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).