* [PATCH 13/17] fs/nfs: remove unnecessary new_valid_dev check
[not found] <1443446807-4838-1-git-send-email-bywxiaobai@163.com>
@ 2015-09-28 14:30 ` Yaowei Bai
0 siblings, 0 replies; only message in thread
From: Yaowei Bai @ 2015-09-28 14:30 UTC (permalink / raw)
To: viro, trond.myklebust, anna.schumaker
Cc: linux-nfs, linux-fsdevel, linux-kernel
As new_valid_dev always returns 1, so !new_valid_dev check is not
needed, remove it.
Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
---
fs/nfs/dir.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 3d8e4ff..ce5a218 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -1714,9 +1714,6 @@ nfs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, dev_t rdev)
dfprintk(VFS, "NFS: mknod(%s/%lu), %pd\n",
dir->i_sb->s_id, dir->i_ino, dentry);
- if (!new_valid_dev(rdev))
- return -EINVAL;
-
attr.ia_mode = mode;
attr.ia_valid = ATTR_MODE;
--
1.9.1
^ permalink raw reply related [flat|nested] only message in thread