From: Trond Myklebust <trond.myklebust@primarydata.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
lawa@nvidia.com,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>
Subject: Re: RCU caching regression in kernel v4.1+
Date: Thu, 08 Oct 2015 08:54:40 -0400 [thread overview]
Message-ID: <1444308880.43040.1.camel@primarydata.com> (raw)
In-Reply-To: <CAHQdGtQTDeYN4ZQn8=zV4WwTQG-FWoLNb4H-kTwJo_nRsy3g6g@mail.gmail.com>
On Wed, 2015-10-07 at 14:57 -0400, Trond Myklebust wrote:
> Hi Al,
>
> Please could you take a look at the bugzilla entry in
> https://bugzilla.kernel.org/show_bug.cgi?id=104911 ?
>
> It describes a NFS caching regression that appears to be caused by
> commit 766c4cbfacd8634d7580bac6a1b8456e63de3e84 ("namei:
> d_is_negative() should be checked before ->d_seq validation").
>
> Shouldn't that test for 'if (negative) return -ENOENT;' happen after
> the call to d_revalidate() in lookup_fast()? If not, we can end up
> caching negative dentries forever, AFAICS...
>
> Cheers
> Trond
Leandro, can you please test if the following patch helps in any way?
Cheers
Trond
8<-----------------------------------------------------------------
next prev parent reply other threads:[~2015-10-08 12:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 18:57 RCU caching regression in kernel v4.1+ Trond Myklebust
2015-10-08 12:54 ` Trond Myklebust [this message]
2015-10-08 17:28 ` Leandro Awa
2015-10-09 0:01 ` Leandro Awa
2015-10-09 17:44 ` [PATCH] namei: results of d_is_negative() should be checked after dentry revalidation Trond Myklebust
2015-10-10 0:19 ` Linus Torvalds
2015-10-10 1:36 ` Al Viro
2015-10-10 17:13 ` Al Viro
2015-10-10 17:19 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444308880.43040.1.camel@primarydata.com \
--to=trond.myklebust@primarydata.com \
--cc=lawa@nvidia.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox