From: Christoph Hellwig <hch@lst.de>
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH] nfsd/blocklayout: accept any minlength
Date: Fri, 9 Oct 2015 15:03:26 +0200 [thread overview]
Message-ID: <1444395806-32111-1-git-send-email-hch@lst.de> (raw)
Recent Linux clients have started to send less than blocksize minglength
requests. Given that minlength is just a hint except for the magic value
of zero just don't check for it except for same zero value. Without
this we'll hang forever during fsx runs.
Cc: stable@vger.kernel.org
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/nfsd/blocklayout.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/fs/nfsd/blocklayout.c b/fs/nfsd/blocklayout.c
index cdefaa3..c29d942 100644
--- a/fs/nfsd/blocklayout.c
+++ b/fs/nfsd/blocklayout.c
@@ -56,14 +56,6 @@ nfsd4_block_proc_layoutget(struct inode *inode, const struct svc_fh *fhp,
u32 device_generation = 0;
int error;
- /*
- * We do not attempt to support I/O smaller than the fs block size,
- * or not aligned to it.
- */
- if (args->lg_minlength < block_size) {
- dprintk("pnfsd: I/O too small\n");
- goto out_layoutunavailable;
- }
if (seg->offset & (block_size - 1)) {
dprintk("pnfsd: I/O misaligned\n");
goto out_layoutunavailable;
--
1.9.1
next reply other threads:[~2015-10-09 13:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 13:03 Christoph Hellwig [this message]
2015-10-09 15:28 ` [PATCH] nfsd/blocklayout: accept any minlength J. Bruce Fields
2015-10-09 17:04 ` Christoph Hellwig
2015-10-09 17:45 ` J. Bruce Fields
2015-10-09 17:54 ` Trond Myklebust
2015-10-09 20:04 ` J. Bruce Fields
2015-10-09 20:14 ` J. Bruce Fields
2015-10-11 13:08 ` Christoph Hellwig
2015-10-12 20:18 ` J. Bruce Fields
2015-10-11 13:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444395806-32111-1-git-send-email-hch@lst.de \
--to=hch@lst.de \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox