* [PATCH] nfsidmapd: allow the usage message to be displayed
@ 2016-02-13 12:54 Steve Dickson
2016-03-16 14:46 ` Steve Dickson
0 siblings, 1 reply; 2+ messages in thread
From: Steve Dickson @ 2016-02-13 12:54 UTC (permalink / raw)
To: Linux NFS Mailing list
xlog_err() never returns. Change the xlog_err(),
when invalid arguments are use, to xlog_warn()
so the second xlog_warn, displaying the usage,
will be called.
Signed-off-by: Steve Dickson <steved@redhat.com>
---
utils/nfsidmap/nfsidmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/nfsidmap/nfsidmap.c b/utils/nfsidmap/nfsidmap.c
index d980c68..2abefe9 100644
--- a/utils/nfsidmap/nfsidmap.c
+++ b/utils/nfsidmap/nfsidmap.c
@@ -430,7 +430,7 @@ int main(int argc, char **argv)
xlog_stderr(verbose);
if ((argc - optind) != 2) {
- xlog_err("Bad arg count. Check /etc/request-key.conf");
+ xlog_warn("Bad arg count. Check /etc/request-key.conf");
xlog_warn(usage, progname);
return EXIT_FAILURE;
}
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfsidmapd: allow the usage message to be displayed
2016-02-13 12:54 [PATCH] nfsidmapd: allow the usage message to be displayed Steve Dickson
@ 2016-03-16 14:46 ` Steve Dickson
0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2016-03-16 14:46 UTC (permalink / raw)
To: Linux NFS Mailing list
On 02/13/2016 07:54 AM, Steve Dickson wrote:
> xlog_err() never returns. Change the xlog_err(),
> when invalid arguments are use, to xlog_warn()
> so the second xlog_warn, displaying the usage,
> will be called.
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed...
steved.
> ---
> utils/nfsidmap/nfsidmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/nfsidmap/nfsidmap.c b/utils/nfsidmap/nfsidmap.c
> index d980c68..2abefe9 100644
> --- a/utils/nfsidmap/nfsidmap.c
> +++ b/utils/nfsidmap/nfsidmap.c
> @@ -430,7 +430,7 @@ int main(int argc, char **argv)
>
> xlog_stderr(verbose);
> if ((argc - optind) != 2) {
> - xlog_err("Bad arg count. Check /etc/request-key.conf");
> + xlog_warn("Bad arg count. Check /etc/request-key.conf");
> xlog_warn(usage, progname);
> return EXIT_FAILURE;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-16 14:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-13 12:54 [PATCH] nfsidmapd: allow the usage message to be displayed Steve Dickson
2016-03-16 14:46 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).