linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] libexport.a: fix missing brace in host_ntop() fallback
@ 2016-02-18 14:20 Stefan Hajnoczi
  2016-03-16 18:19 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Hajnoczi @ 2016-02-18 14:20 UTC (permalink / raw)
  To: linux-nfs; +Cc: Steve Dickson, Stefan Hajnoczi

An if statement has been missing a brace since host_ntop() was added in
commit 94ce1eb94babb4c587b2826452fb053cba745098 ("libexport.a: Add
helpers to manage DNS lookups").

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 support/export/hostname.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/export/hostname.c b/support/export/hostname.c
index 4daabe9..94e98a5 100644
--- a/support/export/hostname.c
+++ b/support/export/hostname.c
@@ -69,7 +69,7 @@ host_ntop(const struct sockaddr *sap, char *buf, const size_t buflen)
 
 	memset(buf, 0, buflen);
 
-	if (sin->sin_family != AF_INET)
+	if (sin->sin_family != AF_INET) {
 		(void)strncpy(buf, "bad family", buflen - 1);
 		return buf;
 	}
-- 
2.5.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] libexport.a: fix missing brace in host_ntop() fallback
  2016-02-18 14:20 [PATCH] libexport.a: fix missing brace in host_ntop() fallback Stefan Hajnoczi
@ 2016-03-16 18:19 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2016-03-16 18:19 UTC (permalink / raw)
  To: Stefan Hajnoczi, linux-nfs



On 02/18/2016 09:20 AM, Stefan Hajnoczi wrote:
> An if statement has been missing a brace since host_ntop() was added in
> commit 94ce1eb94babb4c587b2826452fb053cba745098 ("libexport.a: Add
> helpers to manage DNS lookups").
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Committed... 

steved.

> ---
>  support/export/hostname.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/export/hostname.c b/support/export/hostname.c
> index 4daabe9..94e98a5 100644
> --- a/support/export/hostname.c
> +++ b/support/export/hostname.c
> @@ -69,7 +69,7 @@ host_ntop(const struct sockaddr *sap, char *buf, const size_t buflen)
>  
>  	memset(buf, 0, buflen);
>  
> -	if (sin->sin_family != AF_INET)
> +	if (sin->sin_family != AF_INET) {
>  		(void)strncpy(buf, "bad family", buflen - 1);
>  		return buf;
>  	}
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-03-16 18:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-18 14:20 [PATCH] libexport.a: fix missing brace in host_ntop() fallback Stefan Hajnoczi
2016-03-16 18:19 ` Steve Dickson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).