From: Jeff Layton <jlayton@poochiereds.net>
To: Trond Myklebust <trondmy@primarydata.com>,
Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>
Subject: Re: [PATCH v3 10/13] pnfs: fix bad error handling in send_layoutget
Date: Mon, 16 May 2016 16:08:04 -0400 [thread overview]
Message-ID: <1463429284.26783.23.camel@poochiereds.net> (raw)
In-Reply-To: <FFD84C76-4FD9-403E-9FDE-4FA51C6F9619@primarydata.com>
On Mon, 2016-05-16 at 19:50 +0000, Trond Myklebust wrote:
>
>
> On 5/14/16, 21:06, "Jeff Layton" <jlayton@poochiereds.net> wrote:
>
> >Currently, the code will clear the fail bit if we get back a fatal
> >error. I don't think that's correct -- we only want to clear that
> >bit if the layoutget succeeds.
> >
> >Fixes: 0bcbf039f6 (nfs: handle request add failure properly)
> >Signed-off-by: Jeff Layton <jeff.layton@primarydata.com>
> >---
> > fs/nfs/pnfs.c | 8 +++++---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
> >
> >diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
> >index e6cad5ee5d29..5f6ed295acb5 100644
> >--- a/fs/nfs/pnfs.c
> >+++ b/fs/nfs/pnfs.c
> >@@ -876,11 +876,13 @@ send_layoutget(struct pnfs_layout_hdr *lo,
> > lseg = nfs4_proc_layoutget(lgp, gfp_flags);
> > } while (lseg == ERR_PTR(-EAGAIN));
> >
> >- if (IS_ERR(lseg) && !nfs_error_is_fatal(PTR_ERR(lseg)))
> >- lseg = NULL;
> >- else
> >+ if (IS_ERR(lseg)) {
> >+ if (!nfs_error_is_fatal(PTR_ERR(lseg)))
> >+ lseg = NULL;
> >+ } else {
> > pnfs_layout_clear_fail_bit(lo,
> > pnfs_iomode_to_fail_bit(range->iomode));
> >+ }
>
> No… The intention was indeed that we clear the fail bit in all cases
> except fatal errors. Otherwise, the client won’t attempt another
> layoutget.
>
Got it, thanks. Let me respin, retest and resend. Let me know if you
see any other problems and I'll get those fixed before the next resend.
Thanks!
--
Jeff Layton <jlayton@poochiereds.net>
next prev parent reply other threads:[~2016-05-16 20:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-15 1:06 [PATCH v3 00/13] pnfs: layout pipelining and related fixes Jeff Layton
2016-05-15 1:06 ` [PATCH v3 01/13] pNFS/flexfile: Fix erroneous fall back to read/write through the MDS Jeff Layton
2016-05-15 1:06 ` [PATCH v3 02/13] pNFS/flexfiles: When checking for available DSes, conditionally check for MDS io Jeff Layton
2016-05-15 1:06 ` [PATCH v3 03/13] pNFS/flexfiles: When initing reads or writes, we might have to retry connecting to DSes Jeff Layton
2016-05-15 1:06 ` [PATCH v3 04/13] pnfs: don't merge new ff lsegs with ones that have LAYOUTRETURN bit set Jeff Layton
2016-05-15 1:06 ` [PATCH v3 05/13] pnfs: record sequence in pnfs_layout_segment when it's created Jeff Layton
2016-05-15 1:06 ` [PATCH v3 06/13] pnfs: keep track of the return sequence number in pnfs_layout_hdr Jeff Layton
2016-05-15 1:06 ` [PATCH v3 07/13] pnfs: only tear down lsegs that precede seqid in LAYOUTRETURN args Jeff Layton
2016-05-15 1:06 ` [PATCH v3 08/13] flexfiles: remove pointless setting of NFS_LAYOUT_RETURN_REQUESTED Jeff Layton
2016-05-15 1:06 ` [PATCH v3 09/13] flexfiles: add kerneldoc header to nfs4_ff_layout_prepare_ds Jeff Layton
2016-05-15 1:06 ` [PATCH v3 10/13] pnfs: fix bad error handling in send_layoutget Jeff Layton
2016-05-16 19:50 ` Trond Myklebust
2016-05-16 20:08 ` Jeff Layton [this message]
2016-05-15 1:06 ` [PATCH v3 11/13] pnfs: lift retry logic from send_layoutget to pnfs_update_layout Jeff Layton
2016-05-15 1:06 ` [PATCH v3 12/13] pnfs: rework LAYOUTGET retry handling Jeff Layton
2016-05-17 2:07 ` Trond Myklebust
2016-05-17 10:16 ` Jeff Layton
2016-05-17 12:19 ` Jeff Layton
2016-05-15 1:06 ` [PATCH v3 13/13] pnfs: make pnfs_layout_process more robust Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463429284.26783.23.camel@poochiereds.net \
--to=jlayton@poochiereds.net \
--cc=Anna.Schumaker@netapp.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).