linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paulo Andrade <paulo.cesar.pereira.de.andrade@gmail.com>
To: libtirpc-devel@lists.sourceforge.net
Cc: linux-nfs@vger.kernel.org, Paulo Andrade <pcpa@gnu.org>
Subject: [PATCH 2/3] Record errno value before calling syslog
Date: Thu, 19 May 2016 12:35:09 -0300	[thread overview]
Message-ID: <1463672110-10026-3-git-send-email-pcpa@gnu.org> (raw)
In-Reply-To: <1463672110-10026-1-git-send-email-pcpa@gnu.org>

  Unlikely to change, but stay in the safe side.

Signed-off-by: Paulo Andrade <pcpa@gnu.org>
---
 src/clnt_vc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/clnt_vc.c b/src/clnt_vc.c
index 8af7ddd..0da18ca 100644
--- a/src/clnt_vc.c
+++ b/src/clnt_vc.c
@@ -191,10 +191,10 @@ clnt_vc_create(fd, raddr, prog, vers, sendsz, recvsz)
 	ct = (struct ct_data *)mem_alloc(sizeof (*ct));
 	if ((cl == (CLIENT *)NULL) || (ct == (struct ct_data *)NULL)) {
 		struct rpc_createerr *ce = &get_rpc_createerr();
-		(void) syslog(LOG_ERR, clnt_vc_errstr,
-		    clnt_vc_str, __no_mem_str);
 		ce->cf_stat = RPC_SYSTEMERROR;
 		ce->cf_error.re_errno = errno;
+		(void) syslog(LOG_ERR, clnt_vc_errstr,
+		    clnt_vc_str, __no_mem_str);
 		goto err;
 	}
 	ct->ct_addr.buf = NULL;
-- 
1.8.3.1


  parent reply	other threads:[~2016-05-19 15:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1463593885-1179-1-git-send-email-pcpa@gnu.org>
2016-05-19 15:35 ` [PATCH v2 0/3] Do not hold clnt_fd_lock mutex during connect Paulo Andrade
2016-05-19 15:35   ` [PATCH 1/3] Make it clear rpc_createerr is thread safe Paulo Andrade
2016-05-19 23:51     ` [Libtirpc-devel] " Ian Kent
2016-06-02 14:50     ` Steve Dickson
2016-05-19 15:35   ` Paulo Andrade [this message]
2016-06-02 14:51     ` [Libtirpc-devel] [PATCH 2/3] Record errno value before calling syslog Steve Dickson
2016-05-19 15:35   ` [PATCH 3/3] Do not hold a global mutex during connect Paulo Andrade
2016-05-20  2:00     ` [Libtirpc-devel] " Ian Kent
2016-06-02 14:51     ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463672110-10026-3-git-send-email-pcpa@gnu.org \
    --to=paulo.cesar.pereira.de.andrade@gmail.com \
    --cc=libtirpc-devel@lists.sourceforge.net \
    --cc=linux-nfs@vger.kernel.org \
    --cc=pcpa@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).