* [PATCH] mount.nfs: added usage output when no arguemnts are given
@ 2016-06-07 18:35 Steve Dickson
2016-06-08 10:52 ` Freeman Zhang
2016-06-08 13:12 ` Steve Dickson
0 siblings, 2 replies; 3+ messages in thread
From: Steve Dickson @ 2016-06-07 18:35 UTC (permalink / raw)
To: Linux NFS Mailing list
Signed-off-by: Steve Dickson <steved@redhat.com>
---
utils/mount/mount_libmount.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/utils/mount/mount_libmount.c b/utils/mount/mount_libmount.c
index fa46d54..1f01f7f 100644
--- a/utils/mount/mount_libmount.c
+++ b/utils/mount/mount_libmount.c
@@ -208,6 +208,7 @@ static int umount_main(struct libmnt_context *cxt, int argc, char **argv)
if (!spec || (*spec != '/' && strchr(spec,':') == NULL)) {
nfs_error(_("%s: no mount point provided"), progname);
+ umount_usage();
return EX_USAGE;
}
@@ -329,6 +330,7 @@ static int mount_main(struct libmnt_context *cxt, int argc, char **argv)
if (!mount_point) {
nfs_error(_("%s: no mount point provided"), progname);
+ mount_usage();
goto err;
}
if (!spec) {
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mount.nfs: added usage output when no arguemnts are given
2016-06-07 18:35 [PATCH] mount.nfs: added usage output when no arguemnts are given Steve Dickson
@ 2016-06-08 10:52 ` Freeman Zhang
2016-06-08 13:12 ` Steve Dickson
1 sibling, 0 replies; 3+ messages in thread
From: Freeman Zhang @ 2016-06-08 10:52 UTC (permalink / raw)
To: Steve Dickson, Linux NFS Mailing list
On 06/08/2016 02:35 AM, Steve Dickson wrote:
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
> utils/mount/mount_libmount.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/utils/mount/mount_libmount.c b/utils/mount/mount_libmount.c
> index fa46d54..1f01f7f 100644
> --- a/utils/mount/mount_libmount.c
> +++ b/utils/mount/mount_libmount.c
> @@ -208,6 +208,7 @@ static int umount_main(struct libmnt_context *cxt, int argc, char **argv)
>
> if (!spec || (*spec != '/' && strchr(spec,':') == NULL)) {
> nfs_error(_("%s: no mount point provided"), progname);
> + umount_usage();
> return EX_USAGE;
> }
>
> @@ -329,6 +330,7 @@ static int mount_main(struct libmnt_context *cxt, int argc, char **argv)
>
> if (!mount_point) {
> nfs_error(_("%s: no mount point provided"), progname);
> + mount_usage();
> goto err;
> }
> if (!spec) {
Reasonable. Ack.
Acked-by: Freeman Zhang <zhezhang@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mount.nfs: added usage output when no arguemnts are given
2016-06-07 18:35 [PATCH] mount.nfs: added usage output when no arguemnts are given Steve Dickson
2016-06-08 10:52 ` Freeman Zhang
@ 2016-06-08 13:12 ` Steve Dickson
1 sibling, 0 replies; 3+ messages in thread
From: Steve Dickson @ 2016-06-08 13:12 UTC (permalink / raw)
To: Linux NFS Mailing list
On 06/07/2016 02:35 PM, Steve Dickson wrote:
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
> utils/mount/mount_libmount.c | 2 ++
> 1 file changed, 2 insertions(+)
Committed...
steved.
>
> diff --git a/utils/mount/mount_libmount.c b/utils/mount/mount_libmount.c
> index fa46d54..1f01f7f 100644
> --- a/utils/mount/mount_libmount.c
> +++ b/utils/mount/mount_libmount.c
> @@ -208,6 +208,7 @@ static int umount_main(struct libmnt_context *cxt, int argc, char **argv)
>
> if (!spec || (*spec != '/' && strchr(spec,':') == NULL)) {
> nfs_error(_("%s: no mount point provided"), progname);
> + umount_usage();
> return EX_USAGE;
> }
>
> @@ -329,6 +330,7 @@ static int mount_main(struct libmnt_context *cxt, int argc, char **argv)
>
> if (!mount_point) {
> nfs_error(_("%s: no mount point provided"), progname);
> + mount_usage();
> goto err;
> }
> if (!spec) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-08 13:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-07 18:35 [PATCH] mount.nfs: added usage output when no arguemnts are given Steve Dickson
2016-06-08 10:52 ` Freeman Zhang
2016-06-08 13:12 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).