linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Sorenson <sorenson@redhat.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 0/3] sunrpc: Fix reserved port range calculation and possible panic
Date: Fri,  8 Jul 2016 16:35:22 -0500	[thread overview]
Message-ID: <1468013725-22835-1-git-send-email-sorenson@redhat.com> (raw)

The range calculation for choosing the random reserved port will panic
with divide-by-zero when min_resvport == max_resvport, a range of one
port, not zero.

In addition, the sysctl and kernel module parameters only limit the
min_resvport and max_resvport values to the entire range of allowed
ports, so the min and max may become inverted, with max_resvport
set to a value lower than min_resvport.

These patches address both issues by correcting the port range
calculation and setting the min_resvport/max_resvport limits
to be dependent on each other.

Signed-off-by: Frank Sorenson <sorenson@redhat.com>


[PATCH 1/3] sunrpc: Fix reserved port range calculation
[PATCH 2/3] sunrpc: Prevent resvport min/max inversion via sysctl
[PATCH 3/3] sunrpc: Prevent resvport min/max inversion via sysfs and

             reply	other threads:[~2016-07-08 21:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 21:35 Frank Sorenson [this message]
2016-07-08 21:35 ` [PATCH 1/3] sunrpc: Fix reserved port range calculation Frank Sorenson
2016-07-08 21:35 ` [PATCH 2/3] sunrpc: Prevent resvport min/max inversion via sysctl Frank Sorenson
2016-07-08 21:35 ` [PATCH 3/3] sunrpc: Prevent resvport min/max inversion via sysfs and module parameter Frank Sorenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468013725-22835-1-git-send-email-sorenson@redhat.com \
    --to=sorenson@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).