From: Jeff Layton <jlayton@redhat.com>
To: trond.myklebust@primarydata.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 0/9] nfs: add CB_NOTIFY_LOCK support to nfs client
Date: Tue, 6 Sep 2016 11:12:31 -0400 [thread overview]
Message-ID: <1473174760-29859-1-git-send-email-jlayton@redhat.com> (raw)
This patchset adds support for CB_NOTIFY_LOCK callbacks to the NFS
client. The basic idea is to add a waitqueue to the nfs_client and then
have blocking lock waiters wait on that queue for callbacks.
When a callback comes in, we use a keyed wakeup to wake any waiters. The
waitqueue handling is necessarily more "manual" than I would like, but I
don't see a real alternative there given that we need to insert the
waiters onto the waitqueue prior to sending the lock request, and
sending a lock request can involve blocking operations.
Tested in conjunction with the corresponding knfsd server-side patchset.
Jeff Layton (9):
nfs: the length argument to read_buf should be unsigned
nfs: eliminate pointless and confusing do_vfs_lock wrappers
nfs: check for POSIX lock capability on server even for flock locks
nfs: add a freezable_schedule_timeout_unsafe() and use it when waiting
to retry LOCK
nfs: add handling for CB_NOTIFY_LOCK in client
nfs: move nfs4_set_lock_state call into caller
nfs: add code to allow client to wait on lock callbacks
nfs: ensure that the filehandle in CB_NOTIFY_LOCK request matches the
inode
nfs: track whether server sets MAY_NOTIFY_LOCK flag
fs/nfs/callback.h | 8 ++++
fs/nfs/callback_proc.c | 20 ++++++++
fs/nfs/callback_xdr.c | 51 +++++++++++++++++++-
fs/nfs/file.c | 9 +---
fs/nfs/nfs4_fs.h | 1 +
fs/nfs/nfs4client.c | 1 +
fs/nfs/nfs4proc.c | 118 +++++++++++++++++++++++++++++++++++++---------
include/linux/freezer.h | 13 +++++
include/linux/nfs_fs_sb.h | 1 +
9 files changed, 190 insertions(+), 32 deletions(-)
--
2.7.4
next reply other threads:[~2016-09-06 15:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 15:12 Jeff Layton [this message]
2016-09-06 15:12 ` [PATCH 1/9] nfs: the length argument to read_buf should be unsigned Jeff Layton
2016-09-08 17:39 ` Anna Schumaker
2016-09-08 18:19 ` Jeff Layton
2016-09-06 15:12 ` [PATCH 2/9] nfs: eliminate pointless and confusing do_vfs_lock wrappers Jeff Layton
2016-09-06 15:12 ` [PATCH 3/9] nfs: check for POSIX lock capability on server even for flock locks Jeff Layton
2016-09-06 15:12 ` [PATCH 4/9] nfs: add a freezable_schedule_timeout_unsafe() and use it when waiting to retry LOCK Jeff Layton
2016-09-06 16:39 ` Jeff Layton
2016-09-08 18:20 ` Anna Schumaker
2016-09-08 18:36 ` Jeff Layton
2016-09-06 15:12 ` [PATCH 5/9] nfs: add handling for CB_NOTIFY_LOCK in client Jeff Layton
2016-09-08 20:11 ` Anna Schumaker
2016-09-06 15:12 ` [PATCH 6/9] nfs: move nfs4_set_lock_state call into caller Jeff Layton
2016-09-08 19:47 ` Anna Schumaker
2016-09-08 21:41 ` Jeff Layton
2016-09-06 15:12 ` [PATCH 7/9] nfs: add code to allow client to wait on lock callbacks Jeff Layton
2016-09-08 19:59 ` Anna Schumaker
2016-09-08 21:42 ` Jeff Layton
2016-09-06 15:12 ` [PATCH 8/9] nfs: ensure that the filehandle in CB_NOTIFY_LOCK request matches the inode Jeff Layton
2016-09-08 20:07 ` Anna Schumaker
2016-09-08 21:43 ` Jeff Layton
2016-09-06 15:12 ` [PATCH 9/9] nfs: track whether server sets MAY_NOTIFY_LOCK flag Jeff Layton
2016-09-08 20:15 ` Anna Schumaker
2016-09-08 21:47 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473174760-29859-1-git-send-email-jlayton@redhat.com \
--to=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).