From: Jeff Layton <jlayton@redhat.com>
To: Anna Schumaker <Anna.Schumaker@netapp.com>,
trond.myklebust@primarydata.com
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 05/10] nfs: track whether server sets MAY_NOTIFY_LOCK flag
Date: Mon, 12 Sep 2016 16:30:23 -0400 [thread overview]
Message-ID: <1473712223.8504.2.camel@redhat.com> (raw)
In-Reply-To: <68634996-8fba-5bcd-27e3-5d6ab5f881ba@Netapp.com>
On Mon, 2016-09-12 at 16:19 -0400, Anna Schumaker wrote:
> Hi Jeff,
>
> On 09/09/2016 02:47 PM, Jeff Layton wrote:
> >
> > If it does, then always have the client sleep for the max time before
> > repolling for the lock. If it doesn't then we can skip all of the
> > waitqueue handling as well.
> >
> > > > Signed-off-by: Jeff Layton <jlayton@redhat.com>
> > ---
> > fs/nfs/nfs4_fs.h | 1 +
> > fs/nfs/nfs4proc.c | 2 ++
> > 2 files changed, 3 insertions(+)
> >
> > diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h
> > index 9bf64eacba5b..91e4f135a5f2 100644
> > --- a/fs/nfs/nfs4_fs.h
> > +++ b/fs/nfs/nfs4_fs.h
> > @@ -156,6 +156,7 @@ enum {
> > > > > > NFS_STATE_RECLAIM_NOGRACE, /* OPEN stateid needs to recover state */
> > > > > > NFS_STATE_POSIX_LOCKS, /* Posix locks are supported */
> > > > > > NFS_STATE_RECOVERY_FAILED, /* OPEN stateid state recovery failed */
> > > > > > + NFS_STATE_MAY_NOTIFY_LOCK, /* server may CB_NOTIFY_LOCK */
>
> Looks like the reason I don't have this flag is because it's added as part of the server patches. I'll coordinate with the nfsd merge to make sure everything is added in the right order!
>
> Thanks,
> Anna
Oh! Yes, that would explain it -- sorry...
Would it help at all to break out the addition of that field into a
separate patch? Just wondering what the right approach is for future
reference.
Thanks,
Jeff
> >
> > };
> >
> > struct nfs4_state {
> > diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> > index 90e8ded0ef82..627a9185822f 100644
> > --- a/fs/nfs/nfs4proc.c
> > +++ b/fs/nfs/nfs4proc.c
> > @@ -2537,6 +2537,8 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata,
> > > > goto out;
> > > > if (server->caps & NFS_CAP_POSIX_LOCK)
> > > > set_bit(NFS_STATE_POSIX_LOCKS, &state->flags);
> > > > + if (opendata->o_res.rflags & NFS4_OPEN_RESULT_MAY_NOTIFY_LOCK)
> > > > + set_bit(NFS_STATE_MAY_NOTIFY_LOCK, &state->flags);
> >
> > > > dentry = opendata->dentry;
> > > > if (d_really_is_negative(dentry)) {
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2016-09-12 20:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 18:47 [PATCH v2 00/10] nfs: add CB_NOTIFY_LOCK support to nfs client Jeff Layton
2016-09-09 18:47 ` [PATCH v2 01/10] nfs: the length argument to read_buf should be unsigned Jeff Layton
2016-09-09 18:47 ` [PATCH v2 02/10] nfs: eliminate pointless and confusing do_vfs_lock wrappers Jeff Layton
2016-09-09 18:47 ` [PATCH v2 03/10] nfs: check for POSIX lock capability on server even for flock locks Jeff Layton
2016-09-09 18:47 ` [PATCH v2 04/10] nfs: use safe, interruptible sleeps when waiting to retry LOCK Jeff Layton
2016-09-09 18:47 ` [PATCH v2 05/10] nfs: track whether server sets MAY_NOTIFY_LOCK flag Jeff Layton
2016-09-12 20:19 ` Anna Schumaker
2016-09-12 20:30 ` Jeff Layton [this message]
2016-09-12 20:38 ` Anna Schumaker
2016-09-09 18:47 ` [PATCH v2 06/10] nfs: add handling for CB_NOTIFY_LOCK in client Jeff Layton
2016-09-09 18:47 ` [PATCH v2 07/10] nfs: move nfs4_set_lock_state call into caller Jeff Layton
2016-09-09 18:47 ` [PATCH v2 08/10] nfs: move nfs4 lock retry attempt loop to a separate function Jeff Layton
2016-09-09 18:47 ` [PATCH v2 09/10] nfs: add code to allow client to wait on lock callbacks Jeff Layton
2016-09-09 18:48 ` [PATCH v2 10/10] nfs: ensure that the filehandle in CB_NOTIFY_LOCK request matches the inode Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473712223.8504.2.camel@redhat.com \
--to=jlayton@redhat.com \
--cc=Anna.Schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).