linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@primarydata.com>
To: anna.schumaker@netapp.com
Cc: linux-nfs@vger.kernel.org, Oleg Drokin <green@linuxhacker.ru>
Subject: [PATCH v4 00/20] Fix delegation behaviour when server revokes some state
Date: Thu, 15 Sep 2016 12:45:40 -0400	[thread overview]
Message-ID: <1473957960-10001-1-git-send-email-trond.myklebust@primarydata.com> (raw)

According to RFC5661, if any of the SEQUENCE status bits
SEQ4_STATUS_EXPIRED_ALL_STATE_REVOKED,
SEQ4_STATUS_EXPIRED_SOME_STATE_REVOKED, SEQ4_STATUS_ADMIN_STATE_REVOKED,
or SEQ4_STATUS_RECALLABLE_STATE_REVOKED are set, then we need to use
TEST_STATEID to figure out which stateids have been revoked, so we
can acknowledge the loss of state using FREE_STATEID.

While we already do this for open and lock state, we have not been doing
so for all the delegations.

v2: nfs_v4_2_minor_ops needs to set .test_and_free_expired too
v3: Now with added lock revoke fixes and close/delegreturn/locku fixes
v4: Close a bunch of corner cases

Trond Myklebust (20):
  NFSv4.1: Don't deadlock the state manager on the SEQUENCE status flags
  NFSv4.1: Don't check delegations that are already marked as revoked
  NFSv4.1: Allow test_stateid to handle session errors without waiting
  NFSv4.1: Add a helper function to deal with expired stateids
  NFSv4.x: Allow callers of nfs_remove_bad_delegation() to specify a
    stateid
  NFSv4.1: Test delegation stateids when server declares "some state
    revoked"
  NFSv4.1: Deal with server reboots during delegation expiration
    recovery
  NFSv4.1: Don't recheck delegations that have already been checked
  NFSv4.1: Allow revoked stateids to skip the call to TEST_STATEID
  NFSv4.1: Ensure we always run TEST/FREE_STATEID on locks
  NFSv4.1: FREE_STATEID can be asynchronous
  NFSv4.1: Ensure we call FREE_STATEID if needed on
    close/delegreturn/locku
  NFSv4: nfs_inode_find_delegation_state_and_recover() should check all
    stateids
  NFSv4: nfs4_do_handle_exception() handle revoke/expiry of a single
    stateid
  NFSv4: nfs4_handle_delegation_recall_error() handle expiration as
    revoke case
  NFSv4: nfs4_handle_setlk_error() handle expiration as revoke case
  NFSv4.1: nfs4_layoutget_handle_exception handle revoked state
  NFSv4: Pass the stateid to the exception handler in
    nfs4_read/write_done_cb
  NFSv4: Fix a race in nfs_inode_reclaim_delegation()
  NFSv4: Fix a race when updating an open_stateid

 fs/nfs/delegation.c                    | 183 +++++++++++++++--
 fs/nfs/delegation.h                    |   8 +-
 fs/nfs/flexfilelayout/flexfilelayout.c |   2 +-
 fs/nfs/nfs4_fs.h                       |   5 +-
 fs/nfs/nfs4proc.c                      | 364 ++++++++++++++++++++++-----------
 fs/nfs/nfs4session.h                   |   1 +
 fs/nfs/nfs4state.c                     |  73 +++++--
 include/linux/nfs4.h                   |   1 +
 8 files changed, 490 insertions(+), 147 deletions(-)

-- 
2.7.4


             reply	other threads:[~2016-09-15 16:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 16:45 Trond Myklebust [this message]
2016-09-15 16:45 ` [PATCH v4 01/20] NFSv4.1: Don't deadlock the state manager on the SEQUENCE status flags Trond Myklebust
2016-09-15 16:45   ` [PATCH v4 02/20] NFSv4.1: Don't check delegations that are already marked as revoked Trond Myklebust
2016-09-15 16:45     ` [PATCH v4 03/20] NFSv4.1: Allow test_stateid to handle session errors without waiting Trond Myklebust
2016-09-15 16:45       ` [PATCH v4 04/20] NFSv4.1: Add a helper function to deal with expired stateids Trond Myklebust
2016-09-15 16:45         ` [PATCH v4 05/20] NFSv4.x: Allow callers of nfs_remove_bad_delegation() to specify a stateid Trond Myklebust
2016-09-15 16:45           ` [PATCH v4 06/20] NFSv4.1: Test delegation stateids when server declares "some state revoked" Trond Myklebust
2016-09-15 16:45             ` [PATCH v4 07/20] NFSv4.1: Deal with server reboots during delegation expiration recovery Trond Myklebust
2016-09-15 16:45               ` [PATCH v4 08/20] NFSv4.1: Don't recheck delegations that have already been checked Trond Myklebust
2016-09-15 16:45                 ` [PATCH v4 09/20] NFSv4.1: Allow revoked stateids to skip the call to TEST_STATEID Trond Myklebust
2016-09-15 16:45                   ` [PATCH v4 10/20] NFSv4.1: Ensure we always run TEST/FREE_STATEID on locks Trond Myklebust
2016-09-15 16:45                     ` [PATCH v4 11/20] NFSv4.1: FREE_STATEID can be asynchronous Trond Myklebust
2016-09-15 16:45                       ` [PATCH v4 12/20] NFSv4.1: Ensure we call FREE_STATEID if needed on close/delegreturn/locku Trond Myklebust
2016-09-15 16:45                         ` [PATCH v4 13/20] NFSv4: nfs_inode_find_delegation_state_and_recover() should check all stateids Trond Myklebust
2016-09-15 16:45                           ` [PATCH v4 14/20] NFSv4: nfs4_do_handle_exception() handle revoke/expiry of a single stateid Trond Myklebust
2016-09-15 16:45                             ` [PATCH v4 15/20] NFSv4: nfs4_handle_delegation_recall_error() handle expiration as revoke case Trond Myklebust
2016-09-15 16:45                               ` [PATCH v4 16/20] NFSv4: nfs4_handle_setlk_error() " Trond Myklebust
2016-09-15 16:45                                 ` [PATCH v4 17/20] NFSv4.1: nfs4_layoutget_handle_exception handle revoked state Trond Myklebust
2016-09-15 16:45                                   ` [PATCH v4 18/20] NFSv4: Pass the stateid to the exception handler in nfs4_read/write_done_cb Trond Myklebust
2016-09-15 16:45                                     ` [PATCH v4 19/20] NFSv4: Fix a race in nfs_inode_reclaim_delegation() Trond Myklebust
2016-09-15 16:46                                       ` [PATCH v4 20/20] NFSv4: Fix a race when updating an open_stateid Trond Myklebust
2016-09-15 22:17                                         ` kbuild test robot
2016-09-16  4:38 ` [PATCH v4 00/20] Fix delegation behaviour when server revokes some state Oleg Drokin
2016-09-16 15:36   ` Trond Myklebust
2016-09-16 21:15     ` Oleg Drokin
2016-09-16 21:21       ` Oleg Drokin
2016-09-16 21:28         ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473957960-10001-1-git-send-email-trond.myklebust@primarydata.com \
    --to=trond.myklebust@primarydata.com \
    --cc=anna.schumaker@netapp.com \
    --cc=green@linuxhacker.ru \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).