From: Daniel Wagner <wagi@monom.org>
To: linux-nfs@vger.kernel.org
Cc: Anna Schumaker <anna.schumaker@netapp.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
linux-kernel@vger.kernel.org,
Daniel Wagner <daniel.wagner@bmw-carit.de>
Subject: [PATCH 2/2] NFS: cache_lib: use complete() instead of complete_all()
Date: Thu, 22 Sep 2016 13:54:29 +0200 [thread overview]
Message-ID: <1474545269-8694-3-git-send-email-wagi@monom.org> (raw)
In-Reply-To: <1474545269-8694-1-git-send-email-wagi@monom.org>
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().
The generic caching code from sunrpc is calling revisit() only once.
The usage pattern of the completion is:
waiter context waker context
do_cache_lookup_wait()
nfs_cache_defer_req_alloc()
init_completion()
do_cache_lookup()
nfs_cache_wait_for_upcall()
wait_for_completion_timeout()
nfs_dns_cache_revisit()
complete()
nfs_cache_defer_req_put()
Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
---
fs/nfs/cache_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfs/cache_lib.c b/fs/nfs/cache_lib.c
index 5f7b053..6de1570 100644
--- a/fs/nfs/cache_lib.c
+++ b/fs/nfs/cache_lib.c
@@ -76,7 +76,7 @@ static void nfs_dns_cache_revisit(struct cache_deferred_req *d, int toomany)
dreq = container_of(d, struct nfs_cache_defer_req, deferred_req);
- complete_all(&dreq->completion);
+ complete(&dreq->completion);
nfs_cache_defer_req_put(dreq);
}
--
2.7.4
next prev parent reply other threads:[~2016-09-22 11:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 11:54 [PATCH 0/2] NFS: Use complete() instead complete_all() Daniel Wagner
2016-09-22 11:54 ` [PATCH 1/2] NFS: direct: use complete() instead of complete_all() Daniel Wagner
2016-09-22 11:54 ` Daniel Wagner [this message]
2016-09-23 13:48 ` [PATCH 0/2] NFS: Use complete() instead complete_all() Anna Schumaker
2016-09-26 5:33 ` Daniel Wagner
2016-09-26 13:31 ` Anna Schumaker
2016-09-27 7:42 ` Daniel Wagner
2016-09-27 8:33 ` Daniel Wagner
2016-09-27 17:15 ` Anna Schumaker
2016-09-27 17:18 ` Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474545269-8694-3-git-send-email-wagi@monom.org \
--to=wagi@monom.org \
--cc=anna.schumaker@netapp.com \
--cc=daniel.wagner@bmw-carit.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).