From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from andre.telenet-ops.be ([195.130.132.53]:55168 "EHLO andre.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933955AbcJQKOq (ORCPT ); Mon, 17 Oct 2016 06:14:46 -0400 From: Geert Uytterhoeven To: Trond Myklebust , Anna Schumaker Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] NFSv4: Fix anonymous member initializer in update_open_stateid() Date: Mon, 17 Oct 2016 12:14:44 +0200 Message-Id: <1476699284-5666-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: With gcc 3.4/4.1/4.2/4.4/4.6/4.8: fs/nfs/nfs4proc.c: In function ‘update_open_stateid’: fs/nfs/nfs4proc.c:1548: warning: missing braces around initializer fs/nfs/nfs4proc.c:1548: warning: (near initialization for ‘freeme.’) Add the missing braces to fix this. Fixes: 1393d9612ba02d8b ("NFSv4: Fix a race when updating an open_stateid") Signed-off-by: Geert Uytterhoeven --- See also commit e0714ec4f9efe7b8 ("nfs: fix anonymous member initializer build failure with older compilers"). My first thought it was an old 4.x thingy, but surprisingly this warning is also generated by gcc 4.8.4. --- fs/nfs/nfs4proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index ad917bd72b38c3b2..6fa34095783239da 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -1545,7 +1545,7 @@ static int update_open_stateid(struct nfs4_state *state, struct nfs_client *clp = server->nfs_client; struct nfs_inode *nfsi = NFS_I(state->inode); struct nfs_delegation *deleg_cur; - nfs4_stateid freeme = {0}; + nfs4_stateid freeme = { { { 0 } } }; int ret = 0; fmode &= (FMODE_READ|FMODE_WRITE); -- 1.9.1