From: Trond Myklebust <trond.myklebust@primarydata.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH v2 3/5] NFSv4: Don't request a GETATTR on open_downgrade.
Date: Mon, 14 Nov 2016 15:55:33 -0500 [thread overview]
Message-ID: <1479156935-34479-4-git-send-email-trond.myklebust@primarydata.com> (raw)
In-Reply-To: <1479156935-34479-3-git-send-email-trond.myklebust@primarydata.com>
If we're not closing the file completely, there is no need to request
close-to-open attributes.
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
---
fs/nfs/nfs4xdr.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
index fc89e5ed07ee..43cc989b5c06 100644
--- a/fs/nfs/nfs4xdr.c
+++ b/fs/nfs/nfs4xdr.c
@@ -2328,7 +2328,6 @@ static void nfs4_xdr_enc_open_downgrade(struct rpc_rqst *req,
encode_sequence(xdr, &args->seq_args, &hdr);
encode_putfh(xdr, args->fh, &hdr);
encode_open_downgrade(xdr, args, &hdr);
- encode_getfattr(xdr, args->bitmask, &hdr);
encode_nops(&hdr);
}
@@ -6115,9 +6114,6 @@ static int nfs4_xdr_dec_open_downgrade(struct rpc_rqst *rqstp,
if (status)
goto out;
status = decode_open_downgrade(xdr, res);
- if (status != 0)
- goto out;
- decode_getfattr(xdr, res->fattr, res->server);
out:
return status;
}
--
2.7.4
next prev parent reply other threads:[~2016-11-14 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 20:55 [PATCH v2 0/5] Optimisations for state management Trond Myklebust
2016-11-14 20:55 ` [PATCH v2 1/5] NFSv4: Don't check file access when reclaiming state Trond Myklebust
2016-11-14 20:55 ` [PATCH v2 2/5] NFSv4: Don't ask for the change attribute " Trond Myklebust
2016-11-14 20:55 ` Trond Myklebust [this message]
2016-11-14 20:55 ` [PATCH v2 4/5] NFSv4: Don't request close-to-open attribute when holding a delegation Trond Myklebust
2016-11-14 20:55 ` [PATCH v2 5/5] NFSv4: Optimise away forced revalidation when we know the attributes are OK Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479156935-34479-4-git-send-email-trond.myklebust@primarydata.com \
--to=trond.myklebust@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).