linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jia He <hejianet@gmail.com>
To: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Serge Hallyn <serge@hallyn.com>,
	"David S. Miller" <davem@davemloft.net>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Mel Gorman <mgorman@techsingularity.net>,
	Kees Cook <keescook@chromium.org>,
	Hugh Dickins <hughd@google.com>,
	Daniel Bristot de Oliveira <bristot@redhat.com>,
	Daniel Cashman <dcashman@google.com>,
	Arnd Bergmann <arnd@arndb.de>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Jeff Layton <jlayton@poochiereds.net>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Jia He <hejianet@gmail.com>
Subject: [PATCH v5 2/2] lockd: change the proc_handler for nsm_use_hostnames
Date: Thu, 15 Dec 2016 15:24:21 +0800	[thread overview]
Message-ID: <1481786661-973-3-git-send-email-hejianet@gmail.com> (raw)
In-Reply-To: <1481786661-973-1-git-send-email-hejianet@gmail.com>

nsm_use_hostnames is a module parameter and it will be exported to sysctl
procfs. This is to let user sometimes change it from userspace. But the
minimal unit for sysctl procfs read/write it sizeof(int).
In big endian system, the converting from/to  bool to/from int will cause
error for proc items.

This patch use a new proc_handler proc_dobool to fixe it.

Signed-off-by: Jia He <hejianet@gmail.com>
---
 fs/lockd/svc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index fc4084e..bd6fcf9 100644
--- a/fs/lockd/svc.c
+++ b/fs/lockd/svc.c
@@ -561,7 +561,7 @@ static struct ctl_table nlm_sysctls[] = {
 		.data		= &nsm_use_hostnames,
 		.maxlen		= sizeof(int),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec,
+		.proc_handler	= proc_dobool,
 	},
 	{
 		.procname	= "nsm_local_state",
-- 
2.5.5


  parent reply	other threads:[~2016-12-15  8:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15  7:24 [PATCH v5 0/2] change the proc handler for nsm_use_hostnames Jia He
2016-12-15  7:24 ` [PATCH v5 1/2] sysctl: introduce new proc handler proc_dobool Jia He
2016-12-15  8:13   ` Pan Xinhui
2017-01-04 21:09   ` J. Bruce Fields
2017-01-05  2:45     ` hejianet
2016-12-15  7:24 ` Jia He [this message]
2016-12-15  8:11   ` [PATCH v5 2/2] lockd: change the proc_handler for nsm_use_hostnames Pan Xinhui
2017-01-04  6:35 ` [PATCH v5 0/2] change the proc handler " hejianet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481786661-973-3-git-send-email-hejianet@gmail.com \
    --to=hejianet@gmail.com \
    --cc=acme@redhat.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=anna.schumaker@netapp.com \
    --cc=arnd@arndb.de \
    --cc=bfields@fieldses.org \
    --cc=bristot@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dcashman@google.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=ebiederm@xmission.com \
    --cc=hughd@google.com \
    --cc=jlayton@poochiereds.net \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=mgorman@techsingularity.net \
    --cc=serge@hallyn.com \
    --cc=subashab@codeaurora.org \
    --cc=trond.myklebust@primarydata.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).