* [PATCH] nfs: Fix "Don't increment lock sequence ID after NFS4ERR_MOVED"
@ 2017-01-26 20:14 Chuck Lever
2017-01-26 20:26 ` Trond Myklebust
0 siblings, 1 reply; 2+ messages in thread
From: Chuck Lever @ 2017-01-26 20:14 UTC (permalink / raw)
To: linux-nfs, trond.myklebust, anna.schumaker
Lock sequence IDs are bumped in decode_lock by calling
nfs_increment_seqid(). nfs_increment_sequid() does not use the
seqid_mutating_err() function fixed in commit 059aa7348241 ("Don't
increment lock sequence ID after NFS4ERR_MOVED").
Fixes: 059aa7348241 ("Don't increment lock sequence ID after ...")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Tested-by: Xuan Qi <xuan.qi@oracle.com>
Cc: stable@vger.kernel.org # v3.7+
---
fs/nfs/nfs4state.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index 90e6193..daeb94e 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -1091,6 +1091,7 @@ static void nfs_increment_seqid(int status, struct nfs_seqid *seqid)
case -NFS4ERR_BADXDR:
case -NFS4ERR_RESOURCE:
case -NFS4ERR_NOFILEHANDLE:
+ case -NFS4ERR_MOVED:
/* Non-seqid mutating errors */
return;
};
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfs: Fix "Don't increment lock sequence ID after NFS4ERR_MOVED"
2017-01-26 20:14 [PATCH] nfs: Fix "Don't increment lock sequence ID after NFS4ERR_MOVED" Chuck Lever
@ 2017-01-26 20:26 ` Trond Myklebust
0 siblings, 0 replies; 2+ messages in thread
From: Trond Myklebust @ 2017-01-26 20:26 UTC (permalink / raw)
To: anna.schumaker@netapp.com, linux-nfs@vger.kernel.org,
chuck.lever@oracle.com
T24gVGh1LCAyMDE3LTAxLTI2IGF0IDE1OjE0IC0wNTAwLCBDaHVjayBMZXZlciB3cm90ZToNCj4g
TG9jayBzZXF1ZW5jZSBJRHMgYXJlIGJ1bXBlZCBpbiBkZWNvZGVfbG9jayBieSBjYWxsaW5nDQo+
IG5mc19pbmNyZW1lbnRfc2VxaWQoKS4gbmZzX2luY3JlbWVudF9zZXF1aWQoKSBkb2VzIG5vdCB1
c2UgdGhlDQo+IHNlcWlkX211dGF0aW5nX2VycigpIGZ1bmN0aW9uIGZpeGVkIGluIGNvbW1pdCAw
NTlhYTczNDgyNDEgKCJEb24ndA0KPiBpbmNyZW1lbnQgbG9jayBzZXF1ZW5jZSBJRCBhZnRlciBO
RlM0RVJSX01PVkVEIikuDQo+IA0KPiBGaXhlczogMDU5YWE3MzQ4MjQxICgiRG9uJ3QgaW5jcmVt
ZW50IGxvY2sgc2VxdWVuY2UgSUQgYWZ0ZXIgLi4uIikNCj4gU2lnbmVkLW9mZi1ieTogQ2h1Y2sg
TGV2ZXIgPGNodWNrLmxldmVyQG9yYWNsZS5jb20+DQo+IFRlc3RlZC1ieTogWHVhbiBRaSA8eHVh
bi5xaUBvcmFjbGUuY29tPg0KPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZyAjIHYzLjcrDQo+
IC0tLQ0KPiDCoGZzL25mcy9uZnM0c3RhdGUuYyB8wqDCoMKgwqAxICsNCj4gwqAxIGZpbGUgY2hh
bmdlZCwgMSBpbnNlcnRpb24oKykNCj4gDQo+IGRpZmYgLS1naXQgYS9mcy9uZnMvbmZzNHN0YXRl
LmMgYi9mcy9uZnMvbmZzNHN0YXRlLmMNCj4gaW5kZXggOTBlNjE5My4uZGFlYjk0ZSAxMDA2NDQN
Cj4gLS0tIGEvZnMvbmZzL25mczRzdGF0ZS5jDQo+ICsrKyBiL2ZzL25mcy9uZnM0c3RhdGUuYw0K
PiBAQCAtMTA5MSw2ICsxMDkxLDcgQEAgc3RhdGljIHZvaWQgbmZzX2luY3JlbWVudF9zZXFpZChp
bnQgc3RhdHVzLA0KPiBzdHJ1Y3QgbmZzX3NlcWlkICpzZXFpZCkNCj4gwqAJCWNhc2UgLU5GUzRF
UlJfQkFEWERSOg0KPiDCoAkJY2FzZSAtTkZTNEVSUl9SRVNPVVJDRToNCj4gwqAJCWNhc2UgLU5G
UzRFUlJfTk9GSUxFSEFORExFOg0KPiArCQljYXNlIC1ORlM0RVJSX01PVkVEOg0KPiDCoAkJCS8q
IE5vbi1zZXFpZCBtdXRhdGluZyBlcnJvcnMgKi8NCj4gwqAJCQlyZXR1cm47DQo+IMKgCX07DQo+
IA0KDQpUaGFua3MhIEFwcGxpZWQuLi4NCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5G
UyBjbGllbnQgbWFpbnRhaW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5
ZGF0YS5jb20NCg==
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-26 20:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-26 20:14 [PATCH] nfs: Fix "Don't increment lock sequence ID after NFS4ERR_MOVED" Chuck Lever
2017-01-26 20:26 ` Trond Myklebust
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).