From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2488020ADF6 for ; Fri, 10 Jan 2025 10:26:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736504811; cv=none; b=AeI/3Y94mv6dikQ6s+dhlUcRmu1jeCtThMo0XSPmsG+R9MAMxy3MzOc3X6JVs1m3XXGG4Ze2Uu8azD3lufncqVtiwAQXW/rrNSen+R3o4LoJ2RI9rtWTSkpS2QWTXfqB0qD1jethAlULkslyrlY7T6rDHT98COv3bOKS8EhkVs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736504811; c=relaxed/simple; bh=gKm53QOMWednHvAn1Hp5E76TzULEEfoZAQo0enSMdCM=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=BJjDotNGM5LrriDCxwV9GcLzCXbsWeBsVFz5jR6NmwEjp+OL3ohJjPLEHxiEMzWYxLD1CpO6zLl1YoJBqtEfOdr5ZH7m6b+xZI7AR2ggBOFhFHghGvziTpzfYdUZk3FW/EWl/mn5e4Wj9IEWD6IuPr1XUShVf7V+ygO1vLgHY4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dyifu4Gd; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dyifu4Gd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736504809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rzzZT1Zke9zTlj6zvMnlZUkmOGaTmsD4VeGtYVxbpAk=; b=dyifu4GdFM+D+7Uvtq1DCoJQo7jSMNIpuwHkkfVFwWfPeWfwKhfHC39fFQKqRTyjpawe+C 0ZpDp2Kg5f++piZa3WlCs8El9gZkEkzR5Fr3qWpQQH14nFntr2SDWPApNMHNp6u9/sGSjr CDaCETsZrQSfiKlw/l2Iz3IHy6iHHMU= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-246-WQhH6MOHPOmFQNYc8wv7Ng-1; Fri, 10 Jan 2025 05:26:46 -0500 X-MC-Unique: WQhH6MOHPOmFQNYc8wv7Ng-1 X-Mimecast-MFC-AGG-ID: WQhH6MOHPOmFQNYc8wv7Ng Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6D8491956053; Fri, 10 Jan 2025 10:26:44 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.12]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F31291954B24; Fri, 10 Jan 2025 10:26:39 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20250110010313.1471063-1-dhowells@redhat.com> <20250110010313.1471063-3-dhowells@redhat.com> To: Herbert Xu Cc: dhowells@redhat.com, Chuck Lever , Trond Myklebust , "David S. Miller" , Marc Dionne , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-crypto@vger.kernel.org, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 2/8] crypto/krb5: Provide Kerberos 5 crypto through AEAD API Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1485675.1736504798.1@warthog.procyon.org.uk> Date: Fri, 10 Jan 2025 10:26:38 +0000 Message-ID: <1485676.1736504798@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Herbert Xu wrote: > rfc8009 is basically the same as authenc. So rather than being an > AEAD algorithm it should really be an AEAD template which takes a > cipher and and a hash as its parameters. That's only half true. If it's acting in checksum mode then it's not an authenc() algo. > In fact, you could probably use authenc directly. However the point of having a library is to abstract those details from the callers. You wanted me to rewrite the library as AEAD algorithms, which I have done as far as I can. This makes the object for each kerberos enctype look the same from the PoV of the clients. I have plans to make the kerberos AEAD use an authenc behind the scenes rather than a cipher plus hash where appropriate as a future evolution, but the optimised authenc drivers (QAT for example) that I can find don't appear to support CTS. So I'm not sure what it is you were envisioning. David