linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: Kinglong Mee <kinglongmee@gmail.com>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	Anna Schumaker <Anna.Schumaker@netapp.com>
Subject: Re: [PATCH] SUNRPC/backchanel: set XPT_CONG_CTRL flag for bc xprt
Date: Tue, 07 Mar 2017 06:11:21 -0500	[thread overview]
Message-ID: <1488885081.2788.0.camel@redhat.com> (raw)
In-Reply-To: <b321152e-cbe8-94b3-498c-1d32e7c7be2d@gmail.com>

On Tue, 2017-03-07 at 17:22 +0800, Kinglong Mee wrote:
> The xprt for backchannel is created separately, not in TCP/UDP code.
> Because without the flags, the requests from NFSv41 backchannel are
> rejected in svc_process_common(),
> 
> 1191         if (versp->vs_need_cong_ctrl &&
> 1192             !test_bit(XPT_CONG_CTRL, &rqstp->rq_xprt->xpt_flags))
> 1193                 goto err_bad_vers;
> 
> Fixes: 5283b03ee5 ("nfs/nfsd/sunrpc: enforce transport...")
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
> ---
>  net/sunrpc/svcsock.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
> index 8931e33..2b720fa 100644
> --- a/net/sunrpc/svcsock.c
> +++ b/net/sunrpc/svcsock.c
> @@ -1635,6 +1635,7 @@ static struct svc_xprt *svc_bc_create_socket(struct svc_serv *serv,
>  
>  	xprt = &svsk->sk_xprt;
>  	svc_xprt_init(net, &svc_tcp_bc_class, xprt, serv);
> +	set_bit(XPT_CONG_CTRL, &svsk->sk_xprt.xpt_flags);
>  
>  	serv->sv_bc_xprt = xprt;
>  

Good catch.

Reviewed-by: Jeff Layton <jlayton@redhat.com>

  reply	other threads:[~2017-03-07 11:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07  9:22 [PATCH] SUNRPC/backchanel: set XPT_CONG_CTRL flag for bc xprt Kinglong Mee
2017-03-07 11:11 ` Jeff Layton [this message]
2017-03-09 20:26   ` J. Bruce Fields
2017-03-10 21:29     ` Benjamin Coddington
2017-03-31 20:44     ` Olga Kornievskaia
2017-04-01  1:07       ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488885081.2788.0.camel@redhat.com \
    --to=jlayton@redhat.com \
    --cc=Anna.Schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=kinglongmee@gmail.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).