From: Jason Yan <yanaijie@huawei.com>
To: <bfields@fieldses.org>, <jlayton@poochiereds.net>,
<linux-nfs@vger.kernel.org>
Cc: <miaoxie@huawei.com>, <zhaohongjiang@huawei.com>,
Jason Yan <yanaijie@huawei.com>
Subject: [PATCH] nfsd: make strdup_if_nonnull static
Date: Thu, 23 Mar 2017 16:57:36 +0800 [thread overview]
Message-ID: <1490259456-15858-1-git-send-email-yanaijie@huawei.com> (raw)
Fixes the following sparse warning:
fs/nfsd/nfs4state.c:1915:5: warning: symbol 'strdup_if_nonnull' was not
declared. Should it be static?
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
fs/nfsd/nfs4state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index e9ef50a..59a9e30 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1912,7 +1912,7 @@ static void copy_clid(struct nfs4_client *target, struct nfs4_client *source)
target->cl_clientid.cl_id = source->cl_clientid.cl_id;
}
-int strdup_if_nonnull(char **target, char *source)
+static int strdup_if_nonnull(char **target, char *source)
{
if (source) {
*target = kstrdup(source, GFP_KERNEL);
--
2.5.0
next reply other threads:[~2017-03-23 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 8:57 Jason Yan [this message]
2017-03-29 21:51 ` [PATCH] nfsd: make strdup_if_nonnull static J. Bruce Fields
2017-03-30 6:50 ` NeilBrown
2017-03-31 20:09 ` J. Bruce Fields
2017-04-03 2:15 ` NeilBrown
2017-04-03 2:39 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490259456-15858-1-git-send-email-yanaijie@huawei.com \
--to=yanaijie@huawei.com \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-nfs@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).