linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Justin Mitchell <jumitche@redhat.com>
To: Steve Dickson <SteveD@RedHat.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 2/3] nfs.conf tidy ups
Date: Fri, 02 Jun 2017 10:05:44 +0100	[thread overview]
Message-ID: <1496394344.4126.36.camel@redhat.com> (raw)
In-Reply-To: <65cbaa98-164b-e6a5-95f3-e6e07703cbb3@RedHat.com>

On Thu, 2017-06-01 at 10:45 -0400, Steve Dickson wrote:
> Hello,
> 
> On 05/22/2017 11:50 AM, Justin Mitchell wrote:
> > Add function to cleanup and free the loaded config
> > 
> > Signed-off-by: Justin Mitchell <jumitche@rehat.com>
> > 
> > ---
> >  support/include/conffile.h |  1 +
> >  support/nfs/conffile.c     | 51 +++++++++++++++++++++++++++++++++++++++-------
> >  2 files changed, 45 insertions(+), 7 deletions(-)
> > 
> > diff --git a/support/include/conffile.h b/support/include/conffile.h
> > index 20b1a32..2d11a52 100644
> > --- a/support/include/conffile.h
> > +++ b/support/include/conffile.h
> > @@ -60,6 +60,7 @@ extern _Bool    conf_get_bool(char *, char *, _Bool);
> >  extern char    *conf_get_str(char *, char *);
> >  extern char    *conf_get_section(char *, char *, char *);
> >  extern void     conf_init(const char *);
> > +extern void     conf_cleanup(void);
> I don't see this being called any where? How is it being used?
> 
> steved.

It is not directly referenced yet, for completeness all of the programs
that use the conf file should call it as part of their shutdown, but of
course thats not vital when your process is exiting anyway.

it will however be more important for a library using the same code, and
for anything that is going to re-load its config or handle multiple
files.  

It also gets used in my memory leak testing.



  reply	other threads:[~2017-06-02  9:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 15:50 [PATCH 2/3] nfs.conf tidy ups Justin Mitchell
2017-06-01 14:45 ` Steve Dickson
2017-06-02  9:05   ` Justin Mitchell [this message]
2017-06-06 14:37 ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496394344.4126.36.camel@redhat.com \
    --to=jumitche@redhat.com \
    --cc=SteveD@RedHat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).