From: Thomas Haynes <Thomas.Haynes@primarydata.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Mailing List Linux NFS <linux-nfs@vger.kernel.org>
Subject: [PATCH] Args need to be the same for replay cache
Date: Wed, 11 Oct 2017 09:48:22 -0700 [thread overview]
Message-ID: <1507740502-5151-1-git-send-email-Thomas.Haynes@primarydata.com> (raw)
From: Tom Haynes <loghyr@primarydata.com>
2.10.6.1.3.1. False Retry
If a requester sent a Sequence operation with a slot ID and sequence
ID that are in the reply cache but the replier detected that the
retried request is not the same as the original request, including a
retry that has different operations or different arguments in the
operations from the original and a retry that uses a different
principal in the RPC request's credential field that translates to a
different user, then this is a false retry. When the replier detects
a false retry, it is permitted (but not always obligated) to return
NFS4ERR_SEQ_FALSE_RETRY in response to the Sequence operation when it
detects a false retry.
Or in other words, sa_cachethis needs to be set or a
server can respond with an error.
Signed-off-by: Tom Haynes <loghyr@primarydata.com>
---
nfs4.1/server41tests/st_sequence.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/nfs4.1/server41tests/st_sequence.py b/nfs4.1/server41tests/st_=
sequence.py
index d8d460c..e1e5f06 100644
--- a/nfs4.1/server41tests/st_sequence.py
+++ b/nfs4.1/server41tests/st_sequence.py
@@ -115,7 +115,7 @@ def testReplayCache001(t, env):
sess1 =3D c1.create_session()
res1 =3D sess1.compound([op.putrootfh()], cache_this=3DTrue)
check(res1)
- res2 =3D sess1.compound([op.putrootfh()], seq_delta=3D0)
+ res2 =3D sess1.compound([op.putrootfh()], cache_this=3DTrue, seq_delta=
=3D0)
check(res2)
res1.tag =3D res2.tag =3D ""
if not nfs4lib.test_equal(res1, res2):
@@ -137,7 +137,7 @@ def testReplayCache002(t, env):
op.rename("%s_1" % env.testname(t), "%s_2" % env.testname(t))]
res1 =3D sess1.compound(ops, cache_this=3DTrue)
check(res1)
- res2 =3D sess1.compound(ops, seq_delta=3D0)
+ res2 =3D sess1.compound(ops, cache_this=3DTrue, seq_delta=3D0)
check(res2)
res1.tag =3D res2.tag =3D ""
if not nfs4lib.test_equal(res1, res2):
@@ -158,7 +158,7 @@ def testReplayCache003(t, env):
sess1 =3D c1.create_session()
res1 =3D sess1.compound([op.putrootfh(), op.lookup("")], cache_this=3D=
True)
check(res1, NFS4ERR_INVAL)
- res2 =3D sess1.compound([op.putrootfh(), op.lookup("")], seq_delta=3D0=
)
+ res2 =3D sess1.compound([op.putrootfh(), op.lookup("")], cache_this=3D=
True, seq_delta=3D0)
check(res2, NFS4ERR_INVAL)
res1.tag =3D res2.tag =3D ""
if not nfs4lib.test_equal(res1, res2):
@@ -176,7 +176,7 @@ def testReplayCache004(t, env):
ops +=3D [op.savefh(), op.rename("", "foo")]
res1 =3D sess1.compound(ops, cache_this=3DTrue)
check(res1, NFS4ERR_INVAL)
- res2 =3D sess1.compound(ops, seq_delta=3D0)
+ res2 =3D sess1.compound(ops, cache_this=3DTrue, seq_delta=3D0)
check(res2, NFS4ERR_INVAL)
res1.tag =3D res2.tag =3D ""
if not nfs4lib.test_equal(res1, res2):
@@ -192,7 +192,7 @@ def testReplayCache005(t, env):
sess1 =3D c1.create_session()
res1 =3D sess1.compound([op.illegal()], cache_this=3DTrue)
check(res1, NFS4ERR_OP_ILLEGAL)
- res2 =3D sess1.compound([op.illegal()], seq_delta=3D0)
+ res2 =3D sess1.compound([op.illegal()], cache_this=3DTrue, seq_delta=
=3D0)
check(res2, NFS4ERR_OP_ILLEGAL)
res1.tag =3D res2.tag =3D ""
if not nfs4lib.test_equal(res1, res2):
@@ -208,7 +208,7 @@ def testReplayCache006(t, env):
sess =3D c.create_session()
res1 =3D sess.compound([])
check(res1)
- res2 =3D sess.compound([], seq_delta=3D0)
+ res2 =3D sess.compound([], cache_this=3DTrue, seq_delta=3D0)
check(res2)
res1.tag =3D res2.tag =3D ""
if not nfs4lib.test_equal(res1, res2):
--=20
2.3.6
next reply other threads:[~2017-10-11 16:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 16:48 Thomas Haynes [this message]
2017-10-12 18:32 ` pynfs replay cache test SEQ9f Thomas Haynes
2017-10-12 19:30 ` Trond Myklebust
2017-10-12 19:49 ` J. Bruce Fields
2017-10-12 21:39 ` [nfsv4] " Thomas Haynes
2017-10-12 21:44 ` J. Bruce Fields
2017-10-12 22:00 ` Tom Haynes
2017-10-13 1:52 ` J. Bruce Fields
2017-10-13 13:34 ` Trond Myklebust
2017-10-13 15:00 ` bfields
2017-10-13 15:26 ` Trond Myklebust
2017-10-13 18:50 ` bfields
2017-10-13 20:19 ` bfields
2017-10-17 21:31 ` bfields
2017-10-16 16:15 ` [nfsv4] " Frank Filz
2018-04-10 19:49 ` [PATCH] Args need to be the same for replay cache J. Bruce Fields
2018-04-24 20:10 ` Olga Kornievskaia
2018-04-24 22:16 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507740502-5151-1-git-send-email-Thomas.Haynes@primarydata.com \
--to=thomas.haynes@primarydata.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).