From: Mike Galbraith <efault@gmx.de>
To: lkml <linux-kernel@vger.kernel.org>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Jeff Layton <jlayton@kernel.org>,
linux-nfs@vger.kernel.org
Subject: Re: NFS: 82ms wakeup latency 4.14-rc4
Date: Mon, 18 Dec 2017 16:31:52 +0100 [thread overview]
Message-ID: <1513611112.7113.1.camel@gmx.de> (raw)
In-Reply-To: <1513610231.7998.13.camel@gmx.de>
On Mon, 2017-12-18 at 16:17 +0100, Mike Galbraith wrote:
>
> ....
> kworker/-7421 0.N.. 82893us : nfs_release_request <-nfs_commit_release_pages
> kworker/-7421 0.N.. 82893us : nfs_unlock_and_release_request <-nfs_commit_release_pages
> kworker/-7421 0.N.. 82893us : nfs_unlock_request <-nfs_unlock_and_release_request
> kworker/-7421 0.N.. 82893us : nfs_page_group_destroy <-nfs_commit_release_pages
> kworker/-7421 0.N.. 82893us : nfs_page_group_sync_on_bit <-nfs_page_group_destroy
> kworker/-7421 0.N.. 82893us : nfs_page_group_lock <-nfs_page_group_sync_on_bit
> kworker/-7421 0.N.. 82893us : nfs_page_group_unlock <-nfs_page_group_sync_on_bit
> kworker/-7421 0.N.. 82893us : nfs_free_request <-nfs_page_group_destroy
> kworker/-7421 0.N.. 82893us : nfs_put_lock_context <-nfs_free_request
> kworker/-7421 0.N.. 82893us : put_nfs_open_context <-nfs_free_request
> kworker/-7421 0.N.. 82893us : __put_nfs_open_context <-nfs_free_request
> kworker/-7421 0.N.. 82894us : kmem_cache_free <-nfs_page_group_destroy
> kworker/-7421 0.N.. 82894us : __slab_free <-kmem_cache_free
> kworker/-7421 0.N.. 82894us : clear_wb_congested <-nfs_commit_release_pages
> kworker/-7421 0.N.. 82894us : nfs_init_cinfo <-nfs_commit_release_pages
> kworker/-7421 0.N.. 82894us : nfs_init_cinfo_from_inode <-nfs_commit_release_pages
> kworker/-7421 0.N.. 82894us : nfs_commit_end <-nfs_commit_release_pages
> kworker/-7421 0.N.. 82894us : nfs_commitdata_release <-rpc_free_task
> kworker/-7421 0.N.. 82894us : put_nfs_open_context <-nfs_commitdata_release
> kworker/-7421 0.N.. 82894us : __put_nfs_open_context <-nfs_commitdata_release
> kworker/-7421 0.N.. 82895us : mempool_free <-rpc_free_task
> kworker/-7421 0.N.. 82895us : mempool_free_slab <-rpc_free_task
> kworker/-7421 0.N.. 82895us : kmem_cache_free <-rpc_free_task
> kworker/-7421 0.N.. 82895us : ___might_sleep <-process_one_work
> kworker/-7421 0.N.. 82895us : _cond_resched <-process_one_work
> kworker/-7421 0dN.1 82895us : rcu_note_context_switch <-__schedule
diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c
index d0543e19098a..b42bf3b21e05 100644
--- a/fs/nfs/pagelist.c
+++ b/fs/nfs/pagelist.c
@@ -428,6 +428,7 @@ void nfs_free_request(struct nfs_page *req)
/* Release struct file and open context */
nfs_clear_request(req);
nfs_page_free(req);
+ cond_resched();
}
void nfs_release_request(struct nfs_page *req)
next prev parent reply other threads:[~2017-12-18 15:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 15:17 NFS: 82ms wakeup latency 4.14-rc4 Mike Galbraith
2017-12-18 15:31 ` Mike Galbraith [this message]
2017-12-18 16:35 ` J. Bruce Fields
2017-12-18 16:48 ` Mike Galbraith
2017-12-18 17:00 ` Mike Galbraith
2017-12-18 17:17 ` Mike Galbraith
2017-12-18 17:27 ` J. Bruce Fields
2017-12-18 17:47 ` Mike Galbraith
2017-12-18 18:34 ` Mike Galbraith
2017-12-18 17:24 ` Trond Myklebust
2017-12-18 17:26 ` Mike Galbraith
2018-01-02 20:29 ` [patch] fs/nfs: Add a resched point to nfs_commit_release_pages() Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513611112.7113.1.camel@gmx.de \
--to=efault@gmx.de \
--cc=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).