* [PATCH -next] NFSv4: Fix error handling in nfs4_sp4_select_mode()
@ 2018-08-02 5:42 Wei Yongjun
0 siblings, 0 replies; only message in thread
From: Wei Yongjun @ 2018-08-02 5:42 UTC (permalink / raw)
To: Trond Myklebust, Anna Schumaker; +Cc: Wei Yongjun, linux-nfs, kernel-janitors
Error code is set in the error handling cases but never used. Fix it.
Fixes: 937e3133cd0b ("NFSv4.1: Ensure we clear the SP4_MACH_CRED flags in nfs4_sp4_select_mode()")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
fs/nfs/nfs4proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index c571ee4..8ae1b8d 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -7785,7 +7785,7 @@ static int nfs4_sp4_select_mode(struct nfs_client *clp,
}
out:
clp->cl_sp4_flags = flags;
- return 0;
+ return ret;
}
struct nfs41_exchange_id_data {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-08-02 7:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-02 5:42 [PATCH -next] NFSv4: Fix error handling in nfs4_sp4_select_mode() Wei Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).