From: "J. Bruce Fields" <bfields@fieldses.org>
To: Steve Dickson <steved@redhat.com>
Cc: linux-nfs@vger.kernel.org, "J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 2/2] mountd: always root squash on the pseudofs
Date: Wed, 2 Dec 2020 17:56:44 -0500 [thread overview]
Message-ID: <1606949804-31417-2-git-send-email-bfields@fieldses.org> (raw)
In-Reply-To: <1606949804-31417-1-git-send-email-bfields@fieldses.org>
From: "J. Bruce Fields" <bfields@redhat.com>
As with security flavors and "secure" ports, we tried to code this so
that pseudofs directories would inherit root squashing from their
children, but it doesn't really work as coded and I'm not sure it's
useful.
Just root squash always. If it turns out somebody's exporting
directories that are only readable by root, I guess we can try to do
something else here, but frankly that sounds like a pretty weird
configuration.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
utils/mountd/v4root.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/utils/mountd/v4root.c b/utils/mountd/v4root.c
index 2ac4e87898c0..36543401f296 100644
--- a/utils/mountd/v4root.c
+++ b/utils/mountd/v4root.c
@@ -60,8 +60,6 @@ set_pseudofs_security(struct exportent *pseudo, int flags)
struct flav_info *flav;
int i;
- if ((flags & NFSEXP_ROOTSQUASH) == 0)
- pseudo->e_flags &= ~NFSEXP_ROOTSQUASH;
for (flav = flav_map; flav < flav_map + flav_map_size; flav++) {
struct sec_entry *new;
--
2.28.0
next prev parent reply other threads:[~2020-12-02 22:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 22:56 [PATCH 1/2] mountd: allow high ports on all pseudofs exports J. Bruce Fields
2020-12-02 22:56 ` J. Bruce Fields [this message]
2020-12-03 0:54 ` [PATCH 2/2] mountd: always root squash on the pseudofs Trond Myklebust
2020-12-03 1:05 ` J. Bruce Fields
2020-12-03 1:14 ` [PATCH 1/2] mountd: allow high ports on all pseudofs exports bfields
2020-12-03 1:14 ` [PATCH 2/2] mountd: never root squash on the pseudofs bfields
2020-12-26 19:32 ` Steve Dickson
2020-12-02 23:03 ` [PATCH 1/2] mountd: allow high ports on all pseudofs exports J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1606949804-31417-2-git-send-email-bfields@fieldses.org \
--to=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).