From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: linux-nfs@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Gao Xiang <hsiangkao@linux.alibaba.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Joseph Qi <joseph.qi@linux.alibaba.com>
Subject: [PATCH] nfs: set block size according to pnfs_blksize first
Date: Wed, 16 Jun 2021 20:44:29 +0800 [thread overview]
Message-ID: <1623847469-150122-1-git-send-email-hsiangkao@linux.alibaba.com> (raw)
When testing fstests with ext4 over nfs 4.2, I found generic/486
failed. The root cause is that the length of its xattr value is
min(st_blksize * 3 / 4, XATTR_SIZE_MAX)
which is 4096 * 3 / 4 = 3072 for underlayfs ext4 rather than
XATTR_SIZE_MAX = 65536 for nfs since the block size would be wsize
(=131072) if bsize is not specified.
Let's use pnfs_blksize first instead of using wsize directly if
bsize isn't specified. And the testcase itself can pass now.
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: Anna Schumaker <anna.schumaker@netapp.com>
Cc: Joseph Qi <joseph.qi@linux.alibaba.com>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
Considering bsize is not specified, we might use pnfs_blksize
directly first rather than wsize.
fs/nfs/super.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index fe58525cfed4..5015edf0cd9a 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -1068,9 +1068,13 @@ static void nfs_fill_super(struct super_block *sb, struct nfs_fs_context *ctx)
snprintf(sb->s_id, sizeof(sb->s_id),
"%u:%u", MAJOR(sb->s_dev), MINOR(sb->s_dev));
- if (sb->s_blocksize == 0)
- sb->s_blocksize = nfs_block_bits(server->wsize,
+ if (sb->s_blocksize == 0) {
+ unsigned int blksize = server->pnfs_blksize ?
+ server->pnfs_blksize : server->wsize;
+
+ sb->s_blocksize = nfs_block_bits(blksize,
&sb->s_blocksize_bits);
+ }
nfs_super_set_maxbytes(sb, server->maxfilesize);
server->has_sec_mnt_opts = ctx->has_sec_mnt_opts;
--
1.8.3.1
next reply other threads:[~2021-06-16 12:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 12:44 Gao Xiang [this message]
2021-06-16 13:47 ` [PATCH] nfs: set block size according to pnfs_blksize first Trond Myklebust
2021-06-16 14:06 ` Gao Xiang
2021-06-16 14:20 ` Trond Myklebust
2021-06-16 14:41 ` Gao Xiang
2021-06-16 15:14 ` Trond Myklebust
2021-06-16 17:08 ` Theodore Ts'o
2021-06-16 17:17 ` Frank van der Linden
2021-06-16 22:51 ` Theodore Ts'o
2021-06-16 16:14 ` Theodore Ts'o
2021-06-16 17:51 ` Gao Xiang
2021-06-16 18:51 ` Trond Myklebust
2021-06-16 22:55 ` Theodore Ts'o
2021-06-17 2:39 ` Gao Xiang
2021-06-17 13:08 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623847469-150122-1-git-send-email-hsiangkao@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=anna.schumaker@netapp.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox