From: Dave Wysochanski <dwysocha@redhat.com>
To: Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 4/4] NFS: Fix fscache read from NFS after cache error
Date: Mon, 28 Jun 2021 13:39:03 -0400 [thread overview]
Message-ID: <1624901943-20027-5-git-send-email-dwysocha@redhat.com> (raw)
In-Reply-To: <1624901943-20027-1-git-send-email-dwysocha@redhat.com>
Earlier commits refactored some NFS read code and removed
nfs_readpage_async(), but neglected to properly fixup
nfs_readpage_from_fscache_complete(). The code path is
only hit when something unusual occurs with the cachefiles
backing filesystem, such as an IO error or while a cookie
is being invalidated.
Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
---
fs/nfs/fscache.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/fscache.c b/fs/nfs/fscache.c
index c4c021c6ebbd..d308cb7e1dd4 100644
--- a/fs/nfs/fscache.c
+++ b/fs/nfs/fscache.c
@@ -381,15 +381,25 @@ static void nfs_readpage_from_fscache_complete(struct page *page,
void *context,
int error)
{
+ struct nfs_readdesc desc;
+ struct inode *inode = page->mapping->host;
+
dfprintk(FSCACHE,
"NFS: readpage_from_fscache_complete (0x%p/0x%p/%d)\n",
page, context, error);
- /* if the read completes with an error, we just unlock the page and let
- * the VM reissue the readpage */
if (!error) {
SetPageUptodate(page);
unlock_page(page);
+ } else {
+ desc.ctx = context;
+ nfs_pageio_init_read(&desc.pgio, inode, false,
+ &nfs_async_read_completion_ops);
+ error = readpage_async_filler(&desc, page);
+ if (error)
+ return;
+
+ nfs_pageio_complete_read(&desc.pgio);
}
}
--
1.8.3.1
next prev parent reply other threads:[~2021-06-28 17:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 17:38 [PATCH 0/4] Fix a few error paths in nfs_readpage and fscache Dave Wysochanski
2021-06-28 17:39 ` [PATCH 1/4] NFS: Remove unnecessary inode parameter from nfs_pageio_complete_read() Dave Wysochanski
2021-06-28 17:39 ` [PATCH 2/4] NFS: Ensure nfs_readpage returns promptly when internal error occurs Dave Wysochanski
2021-06-28 19:17 ` Trond Myklebust
2021-06-28 20:00 ` David Wysochanski
2021-06-28 22:00 ` Trond Myklebust
2021-06-28 17:39 ` [PATCH 3/4] NFS: Allow internal use of read structs and functions Dave Wysochanski
2021-06-28 17:39 ` Dave Wysochanski [this message]
2021-06-28 19:09 ` [PATCH 4/4] NFS: Fix fscache read from NFS after cache error Trond Myklebust
2021-06-28 20:15 ` David Wysochanski
2021-06-28 21:12 ` David Wysochanski
2021-06-28 21:59 ` Trond Myklebust
2021-06-28 23:46 ` David Wysochanski
2021-06-29 0:39 ` Trond Myklebust
2021-06-29 9:17 ` David Wysochanski
2021-06-29 12:45 ` Trond Myklebust
2021-06-29 13:20 ` David Wysochanski
2021-06-29 14:54 ` Trond Myklebust
2021-06-29 15:29 ` David Wysochanski
2021-06-29 15:50 ` Trond Myklebust
2021-06-29 15:54 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1624901943-20027-5-git-send-email-dwysocha@redhat.com \
--to=dwysocha@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox