From: patchwork-bot+netdevbpf@kernel.org
To: Xin Xiong <xiongx18@fudan.edu.cn>
Cc: trond.myklebust@hammerspace.com, anna@kernel.org,
chuck.lever@oracle.com, jlayton@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
kolga@netapp.com, linux-nfs@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
yuanxzhang@fudan.edu.cn, tanxin.ctf@gmail.com
Subject: Re: [PATCH] net/sunrpc: fix potential memory leaks in rpc_sysfs_xprt_state_change()
Date: Fri, 12 Aug 2022 10:30:16 +0000 [thread overview]
Message-ID: <166030021671.10916.13511850314728459485.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220810152909.25149-1-xiongx18@fudan.edu.cn>
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 10 Aug 2022 23:29:13 +0800 you wrote:
> The issue happens on some error handling paths. When the function
> fails to grab the object `xprt`, it simply returns 0, forgetting to
> decrease the reference count of another object `xps`, which is
> increased by rpc_sysfs_xprt_kobj_get_xprt_switch(), causing refcount
> leaks. Also, the function forgets to check whether `xps` is valid
> before using it, which may result in NULL-dereferencing issues.
>
> [...]
Here is the summary with links:
- net/sunrpc: fix potential memory leaks in rpc_sysfs_xprt_state_change()
https://git.kernel.org/netdev/net/c/bfc48f1b0505
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-08-12 10:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 15:29 [PATCH] net/sunrpc: fix potential memory leaks in rpc_sysfs_xprt_state_change() Xin Xiong
2022-08-12 10:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166030021671.10916.13511850314728459485.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jlayton@kernel.org \
--cc=kolga@netapp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tanxin.ctf@gmail.com \
--cc=trond.myklebust@hammerspace.com \
--cc=xiongx18@fudan.edu.cn \
--cc=yuanxzhang@fudan.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox