From: Dai Ngo <dai.ngo@oracle.com>
To: chuck.lever@oracle.com, jlayton@kernel.org
Cc: linux-nfs@vger.kernel.org
Subject: PATCH [v3 0/2] NFSD: use CB_GETATTR to handle GETATTR conflict with write delegation
Date: Thu, 15 Feb 2024 14:05:20 -0800 [thread overview]
Message-ID: <1708034722-15329-1-git-send-email-dai.ngo@oracle.com> (raw)
Currently GETATTR conflict with a write delegation is handled by
recalling the delegation before replying to the GETATTR.
This patch series add supports for CB_GETATTR callback to get the latest
change_info and size information of the file from the client that holds
the delegation to reply to the GETATTR from the second client.
NOTE: this patch series is mostly the same as the previous patches which
were backed out when un unrelated problem of NFSD server hang on reboot
was reported.
The only difference is the wait_on_bit() in nfsd4_deleg_getattr_conflict was
replaced with wait_on_bit_timeout() with 30ms timeout to avoid a potential
DOS attack by exhausting NFSD kernel threads with GETATTR conflicts.
v2:
. update comments in nfsd4_deleg_getattr_conflict
v3:
. rebase with nfsd-next
fs/nfsd/nfs4callback.c | 97 ++++++++++++++++++++++++++++++++++++-
fs/nfsd/nfs4state.c | 115 ++++++++++++++++++++++++++++++++++++++++----
fs/nfsd/nfs4xdr.c | 10 +++-
fs/nfsd/nfsd.h | 1 +
fs/nfsd/state.h | 24 ++++++++-
fs/nfsd/xdr4cb.h | 18 +++++++
6 files changed, 251 insertions(+), 14 deletions(-)
next reply other threads:[~2024-02-15 22:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 22:05 Dai Ngo [this message]
2024-02-15 22:05 ` [PATCH v3 1/2] NFSD: add supports for CB_GETATTR callback Dai Ngo
2024-02-15 22:05 ` [PATCH v3 2/2] NFSD: handle GETATTR conflict with write delegation Dai Ngo
2024-02-16 13:36 ` PATCH [v3 0/2] NFSD: use CB_GETATTR to " Chuck Lever
2024-02-16 23:34 ` Dan Shelton
2024-02-17 2:00 ` Trond Myklebust
2024-02-17 2:17 ` Chuck Lever
2024-02-17 17:42 ` dai.ngo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1708034722-15329-1-git-send-email-dai.ngo@oracle.com \
--to=dai.ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox