From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ADD1C54FB9 for ; Fri, 17 Nov 2023 20:11:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231954AbjKQULo (ORCPT ); Fri, 17 Nov 2023 15:11:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232195AbjKQULn (ORCPT ); Fri, 17 Nov 2023 15:11:43 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED11ED6D for ; Fri, 17 Nov 2023 12:11:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700251899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ksp0B0U0jOk91nyenu4kLAdaKIM4KJ+zFPMizD4PhnM=; b=A9KSy6Q7vUA9g+/xEviSoX1Y6y0uVBUrd8fzmbhHReYyF+/+qGw+XDhAs8SXQXYnPmuv7W JuhgmqKG+8yFLbIJWzx9sCI6JQ8G93ztniwvzkjxSbJyZ0iaOC+YtKkMqhb00OxgWpjVuE 7kXBkEHBNQer6nkm1DBY4rmzj4rVYE4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-QOrKvuqrOWOv0BEUCKU0YQ-1; Fri, 17 Nov 2023 15:11:35 -0500 X-MC-Unique: QOrKvuqrOWOv0BEUCKU0YQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 02434848166; Fri, 17 Nov 2023 20:11:34 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4779AC0BDC0; Fri, 17 Nov 2023 20:11:31 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <9d2fc137b4295058ac3f88f1cca7a54bc67f01fd.camel@kernel.org> References: <9d2fc137b4295058ac3f88f1cca7a54bc67f01fd.camel@kernel.org> <20231013160423.2218093-1-dhowells@redhat.com> <20231013160423.2218093-13-dhowells@redhat.com> To: Jeff Layton Cc: dhowells@redhat.com, Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Ilya Dryomov , Christian Brauner , linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cachefs@redhat.com Subject: Re: [RFC PATCH 12/53] netfs: Provide tools to create a buffer in an xarray MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1709497.1700251890.1@warthog.procyon.org.uk> Date: Fri, 17 Nov 2023 20:11:30 +0000 Message-ID: <1709498.1700251890@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Jeff Layton wrote: > Some kerneldoc comments on these new helpers would be nice. I assume > that "index" and "to" are "start" and "end" for this, but it'd be nice > to make that explicit. These are internal to netfs not API functions, so they shouldn't appear in the API docs. That's why the declaration is in internal.h, not netfs.h. That said, I could describe them better. > > + ret = netfs_add_folios_to_buffer(buffer, mapping, want_index, > > + have_index - 1, gfp_mask); > > + if (ret < 0) > > + return ret; > > + have_folios += have_index - want_index; > > + > > + ret = netfs_add_folios_to_buffer(buffer, mapping, > > + have_index + have_folios, > > + want_index + want_folios - 1, > > + gfp_mask); > > I don't get it. Why are you calling netfs_add_folios_to_buffer twice > here? Why not just make one call? Either way, a comment here explaining > that would also be nice. The ranges aren't contiguous. They bracket the folios spliced from the mapping. That being said, I seem to have lost a bit of maths somewhere. Further, I'm not now using netfs_add_folios_to_buffer(), so I'll remove it. David