From: Dai Ngo <dai.ngo@oracle.com>
To: chuck.lever@oracle.com, jlayton@kernel.org
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 1/3] NFSD: mark cl_cb_state as NFSD4_CB_DOWN if cl_cb_client is NULL
Date: Mon, 22 Apr 2024 14:31:13 -0700 [thread overview]
Message-ID: <1713821475-21474-2-git-send-email-dai.ngo@oracle.com> (raw)
In-Reply-To: <1713821475-21474-1-git-send-email-dai.ngo@oracle.com>
In nfsd4_run_cb_work if the rpc_clnt for the back channel is no longer
exists, the callback state in nfs4_client should be marked as NFSD4_CB_DOWN
so the server can notify the client to establish a new back channel
connection when it reconnects.
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
---
fs/nfsd/nfs4callback.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index cf87ace7a1b0..f8bb5ff2e9ac 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -1491,9 +1491,14 @@ nfsd4_run_cb_work(struct work_struct *work)
clnt = clp->cl_cb_client;
if (!clnt) {
- if (test_bit(NFSD4_CLIENT_CB_KILL, &clp->cl_flags))
+ if (test_bit(NFSD4_CLIENT_CB_KILL, &clp->cl_flags)) {
nfsd41_destroy_cb(cb);
- else {
+ clear_bit(NFSD4_CLIENT_CB_KILL, &clp->cl_flags);
+
+ /* let client knows BC is down when it reconnects */
+ clear_bit(NFSD4_CLIENT_CB_UPDATE, &clp->cl_flags);
+ nfsd4_mark_cb_down(clp);
+ } else {
/*
* XXX: Ideally, we could wait for the client to
* reconnect, but I haven't figured out how
--
2.39.3
next prev parent reply other threads:[~2024-04-22 21:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 21:31 PATCH [0/3] NFSD: drop TCP connections when NFSv4 client enters courtesy state Dai Ngo
2024-04-22 21:31 ` Dai Ngo [this message]
2024-04-22 21:31 ` [PATCH 2/3] NFSD: add helper to set NFSD4_CLIENT_CB_KILL to stop the callback Dai Ngo
2024-04-22 21:31 ` [PATCH 3/3] NFSD: drop TCP connections when NFSv4 client enters courtesy state Dai Ngo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1713821475-21474-2-git-send-email-dai.ngo@oracle.com \
--to=dai.ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).