* [PATCH 1/3] NFSD: mark cl_cb_state as NFSD4_CB_DOWN if cl_cb_client is NULL
2024-04-22 21:31 PATCH [0/3] NFSD: drop TCP connections when NFSv4 client enters courtesy state Dai Ngo
@ 2024-04-22 21:31 ` Dai Ngo
2024-04-22 21:31 ` [PATCH 2/3] NFSD: add helper to set NFSD4_CLIENT_CB_KILL to stop the callback Dai Ngo
2024-04-22 21:31 ` [PATCH 3/3] NFSD: drop TCP connections when NFSv4 client enters courtesy state Dai Ngo
2 siblings, 0 replies; 4+ messages in thread
From: Dai Ngo @ 2024-04-22 21:31 UTC (permalink / raw)
To: chuck.lever, jlayton; +Cc: linux-nfs
In nfsd4_run_cb_work if the rpc_clnt for the back channel is no longer
exists, the callback state in nfs4_client should be marked as NFSD4_CB_DOWN
so the server can notify the client to establish a new back channel
connection when it reconnects.
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
---
fs/nfsd/nfs4callback.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index cf87ace7a1b0..f8bb5ff2e9ac 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -1491,9 +1491,14 @@ nfsd4_run_cb_work(struct work_struct *work)
clnt = clp->cl_cb_client;
if (!clnt) {
- if (test_bit(NFSD4_CLIENT_CB_KILL, &clp->cl_flags))
+ if (test_bit(NFSD4_CLIENT_CB_KILL, &clp->cl_flags)) {
nfsd41_destroy_cb(cb);
- else {
+ clear_bit(NFSD4_CLIENT_CB_KILL, &clp->cl_flags);
+
+ /* let client knows BC is down when it reconnects */
+ clear_bit(NFSD4_CLIENT_CB_UPDATE, &clp->cl_flags);
+ nfsd4_mark_cb_down(clp);
+ } else {
/*
* XXX: Ideally, we could wait for the client to
* reconnect, but I haven't figured out how
--
2.39.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 3/3] NFSD: drop TCP connections when NFSv4 client enters courtesy state
2024-04-22 21:31 PATCH [0/3] NFSD: drop TCP connections when NFSv4 client enters courtesy state Dai Ngo
2024-04-22 21:31 ` [PATCH 1/3] NFSD: mark cl_cb_state as NFSD4_CB_DOWN if cl_cb_client is NULL Dai Ngo
2024-04-22 21:31 ` [PATCH 2/3] NFSD: add helper to set NFSD4_CLIENT_CB_KILL to stop the callback Dai Ngo
@ 2024-04-22 21:31 ` Dai Ngo
2 siblings, 0 replies; 4+ messages in thread
From: Dai Ngo @ 2024-04-22 21:31 UTC (permalink / raw)
To: chuck.lever, jlayton; +Cc: linux-nfs
When a v4.0 client enters courtesy state all its v4 states remain valid
and its fore and back channel TCP connection remained in ESTABLISHED
state until the TCP keep-alive mechanism timed out and shuts down the
back channel connection. The fore channel connection remains in ESTABLISHED
state between 6 - 12 minutes before the NFSv4 server's 6-minute idle timer
(svc_age_temp_xprts) shuts down the idle connection.
Since NFSv4.1 mount uses the same TCP connection for both fore and back
channel connection there is no TCP keep-alive packet sent from the server
to the client. The server's idle timer does not shutdown an idle v4.1
connection since the svc_xprt->xpt_ref is more than 1: 1 for sv_tempsocks
list, one for the session's nfsd4_conn and 1 for the back channel.
To conserve system resources in large configuration where there are lots
of idle clients, this patch drops the fore and back channel connection
of NFSv4 client as soon as it enters the courtesy state. The fore and back
channel connections are automatically re-established when the courtesy
client reconnects.
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
---
fs/nfsd/nfs4state.c | 26 +++++++++++++++++++++++++-
fs/nfsd/state.h | 1 +
2 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index a20c2c9d7d45..bafd3f664ff3 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -6369,6 +6369,22 @@ nfs4_anylock_blockers(struct nfs4_client *clp)
return false;
}
+static void nfsd4_drop_conns(struct nfsd_net *nn, struct nfs4_client *clp)
+{
+ struct svc_xprt *xprt;
+
+ /* stop requeueing callback in nfsd4_run_cb_work */
+ nfsd4_kill_callback(clp);
+
+ spin_lock_bh(&nn->nfsd_serv->sv_lock);
+ list_for_each_entry(xprt, &nn->nfsd_serv->sv_tempsocks, xpt_list) {
+ if (rpc_cmp_addr((struct sockaddr *)&clp->cl_addr,
+ (struct sockaddr *)&xprt->xpt_remote))
+ svc_xprt_deferred_close(xprt);
+ }
+ spin_unlock_bh(&nn->nfsd_serv->sv_lock);
+}
+
static void
nfs4_get_client_reaplist(struct nfsd_net *nn, struct list_head *reaplist,
struct laundry_time *lt)
@@ -6376,10 +6392,12 @@ nfs4_get_client_reaplist(struct nfsd_net *nn, struct list_head *reaplist,
unsigned int maxreap, reapcnt = 0;
struct list_head *pos, *next;
struct nfs4_client *clp;
+ struct list_head conn_reaplist;
maxreap = (atomic_read(&nn->nfs4_client_count) >= nn->nfs4_max_clients) ?
NFSD_CLIENT_MAX_TRIM_PER_RUN : 0;
INIT_LIST_HEAD(reaplist);
+ INIT_LIST_HEAD(&conn_reaplist);
spin_lock(&nn->client_lock);
list_for_each_safe(pos, next, &nn->client_lru) {
clp = list_entry(pos, struct nfs4_client, cl_lru);
@@ -6395,8 +6413,11 @@ nfs4_get_client_reaplist(struct nfsd_net *nn, struct list_head *reaplist,
if (!client_has_state(clp))
goto exp_client;
if (!nfs4_anylock_blockers(clp))
- if (reapcnt >= maxreap)
+ if (reapcnt >= maxreap) {
+ if (clp->cl_cb_client)
+ list_add(&clp->cl_conn_lru, &conn_reaplist);
continue;
+ }
exp_client:
if (!mark_client_expired_locked(clp)) {
list_add(&clp->cl_lru, reaplist);
@@ -6404,6 +6425,9 @@ nfs4_get_client_reaplist(struct nfsd_net *nn, struct list_head *reaplist,
}
}
spin_unlock(&nn->client_lock);
+
+ list_for_each_entry(clp, &conn_reaplist, cl_conn_lru)
+ nfsd4_drop_conns(nn, clp);
}
static void
diff --git a/fs/nfsd/state.h b/fs/nfsd/state.h
index cde05c26afd8..fe7b5bd6460b 100644
--- a/fs/nfsd/state.h
+++ b/fs/nfsd/state.h
@@ -420,6 +420,7 @@ struct nfs4_client {
int cl_cb_state;
struct nfsd4_callback cl_cb_null;
struct nfsd4_session *cl_cb_session;
+ struct list_head cl_conn_lru;
/* for all client information that callback code might need: */
spinlock_t cl_lock;
--
2.39.3
^ permalink raw reply related [flat|nested] 4+ messages in thread