Linux NFS development
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: nfs@lists.sourceforge.net
Subject: Re: [PATCH 00/13] RPC server pre-requisites for IPv6
Date: Tue, 30 Jan 2007 16:24:07 +1100	[thread overview]
Message-ID: <17854.54903.29418.138244@notabene.brown> (raw)
In-Reply-To: message from Chuck Lever on Thursday January 18

On Thursday January 18, chuck.lever@oracle.com wrote:
> Hi Neil-
> 
> Please consider these patches for 2.6.21.  They can replace the similar patch
> set that is currently included in Andrew's kernel.  These patches address a
> few minor bugs, and may fix a problem that Andrew is currently seeing.

Thanks Chuck, and sorry for the delay in getting to then.

Once patches are in Andrew's tree it is really a lot easier to get
incremental patches rather than replacements.  For one thing it makes
review much easier.

I couldn't find anything significant in the first 6 patches of what is
in -mm, so I am ignoring them.  If there is something I missed, please
tell me or send an incremental patch.

The remaining 7 (7..13) look fine. 
I noticed you replacing
  struct sockaddr_in *sin
with
  struct sockaddr *sin
a couple of times and wondered if the name should change with the
type (as 'sin' is really an abbreviation of sockaddr_in).  But figured
it is probably fine as it is.

I'll send them off to Andrew shortly.

How much further do we need to go until kernel-side support for an
IPv6 NFS server is all there?  I'm guessing there are not a lot more
placed that need fixing, but some of them might be big fixes ??

Thanks,
NeilBrown

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

      parent reply	other threads:[~2007-01-30  5:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-18 23:48 [PATCH 00/13] RPC server pre-requisites for IPv6 Chuck Lever
2007-01-18 23:50 ` [PATCH 01/13] SUNRPC: update internal API: separate pmap register and temp sockets Chuck Lever
2007-01-18 23:50 ` [PATCH 02/13] SUNRPC: allow creating an RPC service without registering with portmapper Chuck Lever
2007-01-18 23:50 ` [PATCH 03/13] SUNRPC: Cache remote peer's address in svc_sock Chuck Lever
2007-01-18 23:50 ` [PATCH 04/13] SUNRPC: Don't set msg_name and msg_namelen when calling sock_recvmsg Chuck Lever
2007-01-18 23:50 ` [PATCH 05/13] SUNRPC: Add a function to format the address in an svc_rqst for printing Chuck Lever
2007-01-18 23:50 ` [PATCH 06/13] SUNRPC: Use sockaddr_storage to store address in svc_deferred_req Chuck Lever
2007-01-18 23:50 ` [PATCH 07/13] SUNRPC: Provide room in svc_rqst for larger addresses Chuck Lever
2007-01-18 23:50 ` [PATCH 08/13] SUNRPC: Make rq_daddr field address-version independent Chuck Lever
2007-01-18 23:50 ` [PATCH 09/13] SUNRPC: teach svc_sendto() to deal with IPv6 addresses Chuck Lever
2007-01-18 23:50 ` [PATCH 10/13] SUNRPC: add a "generic" function to see if the peer uses a secure port Chuck Lever
2007-01-18 23:50 ` [PATCH 11/13] SUNRPC: Support IPv6 addresses in svc_tcp_accept Chuck Lever
2007-01-18 23:51 ` [PATCH 12/13] SUNRPC: support IPv6 addresses in RPC server's UDP receive path Chuck Lever
2007-01-18 23:51 ` [PATCH 13/13] SUNRPC: fix up svc_create_socket() to take a sockaddr struct + length Chuck Lever
2007-01-30  5:24 ` Neil Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17854.54903.29418.138244@notabene.brown \
    --to=neilb@suse.de \
    --cc=chuck.lever@oracle.com \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox