Linux NFS development
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: nfs@lists.sourceforge.net
Subject: Re: PATCH/RFC Add support for using UUID to identify	filesystem in filehandle
Date: Fri, 9 Feb 2007 21:42:18 +1100	[thread overview]
Message-ID: <17868.20490.168908.226415@notabene.brown> (raw)
In-Reply-To: message from Trond Myklebust on Friday February 2

On Friday February 2, trond.myklebust@fys.uio.no wrote:
> 
> I like the idea of using a UUID. That makes server setup infinitely more
> easy, and should definitely be the default.
> 
> What are the filesystems that support 16 byte UUIDs these days? Should
> we also support hashed labels for those that do not?

libblkid seems to find 16byte uuids for
   ext2, ext3, xfs, reiserfs, reiser4, jfs, ocfs, ocfs2

So that excludes FAT (which has a 4 byte uuid), minix, ISO9660, UDF
and some very minor filesystems.

ISO9660 seems to be the only significant one that has a label but not
a uuid.

> 
> About the code. It would really be nice if you could avoid all these
> open-coded filehandle version numbers and fsid types. Use of a macro or
> enum to name them would certainly help the casual code reviewer. Also,
> names like "mk_fsid_v7" do tend to confuse. Perhaps something like
> mk_fsid_uuid() and mk_fsid_uuid_root_export() (for v6)?

Fair comment.  I'll have a look and a think and see what makes it most
readable.

Thanks,
NeilBrown

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

      reply	other threads:[~2007-02-09 10:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-02 10:15 PATCH/RFC Add support for using UUID to identify filesystem in filehandle Neil Brown
2007-02-02 19:31 ` Trond Myklebust
2007-02-09 10:42   ` Neil Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17868.20490.168908.226415@notabene.brown \
    --to=neilb@suse.de \
    --cc=nfs@lists.sourceforge.net \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox