Re: [PATCH 09/11] nfs-utils: mount: Fixed mounts to multi-home servers

[Neil Brown <neilb@suse.de>]

On Monday February 26, SteveD@redhat.com wrote:
> commit 253c6b866a1ed4678c30131a41ef96821bae9d5f
> Author: Steve Dickson <steved@redhat.com>
> Date:   Sat Feb 24 16:08:22 2007 -0500
> 
>     Doing a connect on UDP sockets causes the Linux network
>     stack to reject UDP patches from multi-home server with
>     nic on the same subnet which caused mounts to hang.
>     
>     Signed-off-by: Steve Dickson <steved@redhat.com>
> 
> diff --git a/support/nfs/conn.c b/support/nfs/conn.c
> index 89f7676..06afcc4 100644
> --- a/support/nfs/conn.c
> +++ b/support/nfs/conn.c
> @@ -98,7 +98,7 @@ int get_socket(struct sockaddr_in *saddr, u_int p_prot, int resvp)
>  			return RPC_ANYSOCK;
>  		}
>  	}
> -	if (type == SOCK_STREAM || type == SOCK_DGRAM) {
> +	if (type == SOCK_STREAM) {

You are reverting a change from commit
   c2db41e8abb6ddc9d03a0c91c6db043fa0f85a8f

This was needed so we could find our local address to get the
call-back address sent to the server right for NFSv4.

I think the correct thing to do here is to fix mountd so that it
replies from the correct address.  Careful use of IP_PKTINFO makes
this fairly easy to manage.... except that the recvfrom and sendto
code is buried inside libc.... but if memory serves, that was fixed to
get this right some time ago.

What OS is running on this multi-homed server??

Maybe we have to do something ghastly like disconnect the socket after
getting the local address...  I hope not.

NeilBrown

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs