Re: [PATCH 11/11] nfs-utils: mount: Fixed collision between commas in options

[Neil Brown <neilb@suse.de>]

On Monday February 26, SteveD@redhat.com wrote:
> commit 96a3ceb3d35bf5edcb9446aded8375d3b98b4f5b
> Author: Cory Olmo <colmo@TrustedCS.com>
> Date:   Sat Feb 24 16:20:40 2007 -0500
> 
>     This patch avoid the collision between commas in security contexts and the
>     delimiter betweeen mount options.
>     
>     Signed-off-by: Karel Zak <kzak@redhat.com>
>     Signed-off-by: Cory Olmo <colmo@TrustedCS.com>
> 
> diff --git a/utils/mount/mount.c b/utils/mount/mount.c
> index b3d3696..f22747b 100644
> --- a/utils/mount/mount.c
> +++ b/utils/mount/mount.c
> @@ -285,18 +285,30 @@ static void parse_opts (const char *options, int *flags, char **extra_opts)
>  {
>  	if (options != NULL) {
>  		char *opts = xstrdup(options);
> -		char *opt;
> -		int len = strlen(opts) + 20;
> -
> +		char *opt, *p;
> +		int len = strlen(opts) + 256;

This is a worry.  If 20 isn't big enough, why do you thing 256 will
be? and where do we check that the buffer doesn't overflow (in this
setuid program).
What are we making space for here?

Would strlen(opts)*2 or *3 be sure to be sufficient?

NeilBrown

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs