Re: [PATCH 0/18] export operations rewrite

[Neil Brown <neilb@suse.de>]

On Saturday March 17, hch@infradead.org wrote:

less that 2 weeks later....

> This patchset is a medium scale rewrite of the export operations
> interface.  The goal is to make the interface less complex, and
> easier to understand from the filesystem side, aswell as preparing
> generic support for exporting of 64bit inode numbers.
> 
> This touches all nfs exporting filesystems, and I've done testing
> on all of the filesystems I have here locally (xfs, ext2, ext3, reiserfs,
> jfs)

My only question involves motivation.

  You say "less complex", but to me it just looks "different" - though
  being very familiar with the original, that might be a biased view.
  Can you say more about how it is less complex?
  Maybe the extension to generic 64bit support will make that clear...

  But then generic 64bit support should just be an independent set of
  helper functions that can be plugged in to the export_operations
  structure.

For what it does, the code looks fine, and I can see some definite
improvements here and there, but I'm not clear on the over-all
motivation.

Thanks,
NeilBrown

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs