From: Neil Brown <neilb@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: nfs@lists.sourceforge.net
Subject: Re: [PATCH] nfsd: fix horrible indentation in nfsd_setattr
Date: Mon, 14 May 2007 10:21:57 +1000 [thread overview]
Message-ID: <17991.43941.702458.638020@notabene.brown> (raw)
In-Reply-To: message from Christoph Hellwig on Sunday May 13
On Sunday May 13, hch@infradead.org wrote:
> On Wed, Mar 07, 2007 at 03:26:25PM +0000, Christoph Hellwig wrote:
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> ping?
>
I don't remember seeing this, and I don't see to still have it sitting
unread in my INBOX...
Except for spending a whole line on "/*" which I would rather avoid
(inside functions) it's all very sensible. I will apply it.
Thanks,
NeilBrown
> >
> > Index: linux-2.6/fs/nfsd/vfs.c
> > ===================================================================
> > --- linux-2.6.orig/fs/nfsd/vfs.c 2007-03-06 17:43:28.000000000 +0100
> > +++ linux-2.6/fs/nfsd/vfs.c 2007-03-06 17:45:48.000000000 +0100
> > @@ -277,7 +277,8 @@
> > if (!iap->ia_valid)
> > goto out;
> >
> > - /* NFSv2 does not differentiate between "set-[ac]time-to-now"
> > + /*
> > + * NFSv2 does not differentiate between "set-[ac]time-to-now"
> > * which only requires access, and "set-[ac]time-to-X" which
> > * requires ownership.
> > * So if it looks like it might be "set both to the same time which
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2007-05-14 0:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 15:26 [PATCH] nfsd: fix horrible indentation in nfsd_setattr Christoph Hellwig
2007-05-13 20:44 ` Christoph Hellwig
2007-05-14 0:21 ` Neil Brown [this message]
2007-07-20 18:49 ` Christoph Hellwig
2007-07-20 19:19 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17991.43941.702458.638020@notabene.brown \
--to=neilb@suse.de \
--cc=hch@infradead.org \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox