Linux NFS development
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: "david m. richter" <richterd@citi.umich.edu>
Cc: nfs@lists.sourceforge.net
Subject: Re: [PATCH 0/5] nfsstat: more --diff-stat/--sleep items
Date: Thu, 9 Aug 2007 11:13:45 +1000	[thread overview]
Message-ID: <18106.27209.93060.7817@notabene.brown> (raw)
In-Reply-To: message from david m. richter on Tuesday August 7

On Tuesday August 7, richterd@citi.umich.edu wrote:
> 	Hello, Neil, 
> 
> 	This set of patches fills in some holes from the initial 
> --diff-stat work.  The first patch maybe should be separate, but the third 
> patch makes use of it (but could easily be reworked).
> 
> 
> - patch 1 adds three counters to the client v4 ops display -- GETACL, 
> SETACL, and FS_LOCATIONS, which are available in /proc/net/rpc/nfs but 
> haven't been used.
> 
> - patch 2 adds, at your suggestion, a comment clarifying what has_stats() 
> is actually doing.
> 
> - patch 3 fixes a bug in diff_stats() that causes false-positives in 
> has_stats().
> 
> - patch 4, as Bruce Fields suggested, renames -D/--diff-stat to 
> the (hopefully) more intuitive -Z/--sleep.
> 
> - patch 5 adds -Z/--sleep to the nfsstat manpage.
> 

Thanks.  All applied (after I wraps your comments to 80 columns, and
removed white space at the end of lines).

NeilBrown

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2007-08-09  1:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-07 23:52 [PATCH 0/5] nfsstat: more --diff-stat/--sleep items david m. richter
2007-08-09  1:13 ` Neil Brown [this message]
2007-08-09 15:29   ` david m. richter
2007-08-10  5:13     ` Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18106.27209.93060.7817@notabene.brown \
    --to=neilb@suse.de \
    --cc=nfs@lists.sourceforge.net \
    --cc=richterd@citi.umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox