From: Neil Brown <neilb@suse.de>
To: "J. Bruce Fields" <bfields@citi.umich.edu>
Cc: linux-nfs@vger.kernel.org,
"Robert P. J. Day" <rpjday@crashcourse.ca>,
nfs@lists.sourceforge.net
Subject: Re: [PATCH 1/2] nfsd: move nfsd/auth.h into fs/nfsd
Date: Fri, 16 Nov 2007 11:31:05 +1100 [thread overview]
Message-ID: <18236.58569.175370.275493@notabene.brown> (raw)
In-Reply-To: message from J. Bruce Fields on Thursday November 15
On Thursday November 15, bfields@citi.umich.edu wrote:
> This header is used only in a few places in fs/nfsd, so there seems to
> be little point to having it in include/. (Thanks to Robert Day for
> pointing this out.)
>
> Cc: Robert P. J. Day <rpjday@crashcourse.ca>
> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Yes, good.
Acked-by: NeilBrown <neilb@suse.de>
But it does beg the question: what other include files could/should be
moved?
cache.h and xdr*.h all seem like good candidates.
Is it worth doing?
NeilBrown
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2007-11-16 0:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 22:53 [PATCH 1/2] nfsd: move nfsd/auth.h into fs/nfsd J. Bruce Fields
2007-11-15 22:53 ` [PATCH 2/2] nfsd: minor fs/nfsd/auth.h cleanup J. Bruce Fields
2007-11-16 0:31 ` Neil Brown [this message]
2007-11-16 3:32 ` [PATCH 1/2] nfsd: move nfsd/auth.h into fs/nfsd J. Bruce Fields
2007-11-16 3:51 ` J. Bruce Fields
2007-11-16 9:15 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18236.58569.175370.275493@notabene.brown \
--to=neilb@suse.de \
--cc=bfields@citi.umich.edu \
--cc=linux-nfs@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox