From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [RFC PATCH v2 0/2] Make NFSD use the vfs_iocb_iter APIs
Date: Fri, 13 Jun 2025 17:01:06 -0400 [thread overview]
Message-ID: <182c1f7de5a3d8e32db5fca9656f6a198c0f7806.camel@kernel.org> (raw)
In-Reply-To: <20250613200847.7155-1-cel@kernel.org>
On Fri, 2025-06-13 at 16:08 -0400, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> Mike has expressed interest in making NFSD perform direct, uncached,
> or asynchronous I/O, independent of how the target file might have
> been opened by the file cache. To do that, the idea is to pass in
> RWF_ flags during each VFS read and write.
>
> However, Christoph suggested APIs that already exist which
> streamline the I/O operation a bit and expose the per-I/O flag
> setting directly. The suggestion looks to me like a straightforward
> and sensible general clean up of these code paths.
>
> This series refactors nfsd_iter_read() and nfsd_vfs_write() to use
> those APIs instead of vfs_iter_read() and vfs_iter_write(),
> respectively, as a first baby step down this path. No behavior
> change is expected.
>
> Chuck Lever (2):
> NFSD: Use vfs_iocb_iter_read()
> NFSD: Use vfs_iocb_iter_write()
>
> fs/nfsd/vfs.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
Looks like a straightforward change to me. Why the RFC?
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2025-06-13 21:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 20:08 [RFC PATCH v2 0/2] Make NFSD use the vfs_iocb_iter APIs Chuck Lever
2025-06-13 20:08 ` [RFC PATCH v2 1/2] NFSD: Use vfs_iocb_iter_read() Chuck Lever
2025-06-16 5:00 ` Christoph Hellwig
2025-06-13 20:08 ` [RFC PATCH v2 2/2] NFSD: Use vfs_iocb_iter_write() Chuck Lever
2025-06-16 5:00 ` Christoph Hellwig
2025-06-13 21:01 ` Jeff Layton [this message]
2025-06-15 22:38 ` [RFC PATCH v2 0/2] Make NFSD use the vfs_iocb_iter APIs NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=182c1f7de5a3d8e32db5fca9656f6a198c0f7806.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox