From: Kinglong Mee <kinglongmee@gmail.com>
To: devel@lists.nfs-ganesha.org, linux-nfs@vger.kernel.org
Cc: kinglongmee@gmail.com
Subject: lseek gets bad offset from nfs client with ganesha/gluster which supports SEEK
Date: Tue, 11 Sep 2018 20:29:34 +0800 [thread overview]
Message-ID: <182fecd3-66c3-0cbd-fbc0-cf1a88b7f165@gmail.com> (raw)
The latest ganesha/gluster supports seek according to,
https://tools.ietf.org/html/draft-ietf-nfsv4-minorversion2-41#section-15.11
From the given sa_offset, find the next data_content4 of type sa_what
in the file. If the server can not find a corresponding sa_what,
then the status will still be NFS4_OK, but sr_eof would be TRUE. If
the server can find the sa_what, then the sr_offset is the start of
that content. If the sa_offset is beyond the end of the file, then
SEEK MUST return NFS4ERR_NXIO.
For a file's filemap as,
Part 1: HOLE 0x0000000000000000 ---> 0x0000000000600000
Part 2: DATA 0x0000000000600000 ---> 0x0000000000700000
Part 3: HOLE 0x0000000000700000 ---> 0x0000000001000000
SEEK(0x700000, SEEK_DATA) gets result (sr_eof:1, sr_offset:0x70000) from ganesha/gluster;
SEEK(0x700000, SEEK_HOLE) gets result (sr_eof:0, sr_offset:0x70000) from ganesha/gluster.
If an application depends the lseek result for data searching, it may enter infinite loop.
while (1) {
next_pos = lseek(fd, cur_pos, seek_type);
if (seek_type == SEEK_DATA) {
seek_type = SEEK_HOLE;
} else {
seek_type = SEEK_DATA;
}
if (next_pos == -1) {
return ;
cur_pos = next_pos;
}
The lseek syscall always gets 0x70000 from nfs client for those two cases,
but, if underlying filesystem is ext4/f2fs, or the nfs server is knfsd,
the lseek(0x700000, SEEK_DATA) gets ENXIO.
I wanna to know,
should I fix the ganesha/gluster as knfsd return ENXIO for the first case?
or should I fix the nfs client to return ENXIO for the first case?
thanks,
Kinglong Mee
next reply other threads:[~2018-09-11 17:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 12:29 Kinglong Mee [this message]
2018-09-11 12:57 ` lseek gets bad offset from nfs client with ganesha/gluster which supports SEEK Trond Myklebust
2018-09-11 14:47 ` Kinglong Mee
2018-09-11 15:43 ` Anna Schumaker
2018-09-11 23:20 ` [NFS-Ganesha-Devel] " Frank Filz
2018-09-12 1:31 ` Kinglong Mee
2018-09-12 11:58 ` Frank Filz
2018-09-13 0:03 ` Kinglong Mee
2020-09-14 15:02 ` Frank Filz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=182fecd3-66c3-0cbd-fbc0-cf1a88b7f165@gmail.com \
--to=kinglongmee@gmail.com \
--cc=devel@lists.nfs-ganesha.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).