From: Neil Brown <neilb@suse.de>
To: Steve Dickson <SteveD@redhat.com>
Cc: chucklever@gmail.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] mount: enable retry for nfs23 to set the correct protocol for mount.
Date: Fri, 18 Jul 2008 08:50:35 +1000 [thread overview]
Message-ID: <18559.52411.176479.699140@notabene.brown> (raw)
In-Reply-To: message from Steve Dickson on Thursday July 17
On Thursday July 17, SteveD@redhat.com wrote:
> > In kernels up to and including 2.6.26, mount reports "connection
> > refused" type messages as EIO rather than EPROTONOSUPPORT.
> > So detect those kernels and don't treat EIO as so fatal.
> Should we just fix the kernel to do the right thing?
Undoubtedly we should fix the kernel to do the right thing.
But some people find it much easier to upgrade user-space tools like
nfs-utils than to upgrade kernels.
We already have code in mount.nfs to cope with earlier kernels which
had less complete interfaces with userspace.
We can see this lack of distinction in error code simple as a less
complete interface in earlier kernels and treat it the same way.
I don't feel so strongly about this that I will fight to the end, but
I really think that if we can make life easier for our users with
compromising our integrity, we should. And handling EIO differently
depending on kernel version seems to fit that goal.
NeilBrown
next prev parent reply other threads:[~2008-07-17 22:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 12:56 [PATCH] mount: enable retry for nfs23 to set the correct protocol for mount Neil Brown
[not found] ` <18556.40594.897682.204554-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-07-15 15:11 ` Chuck Lever
[not found] ` <76bd70e30807150811p56feb02bo6e4a366d5577b398-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-07-16 17:12 ` Steve Dickson
2008-07-17 2:25 ` Neil Brown
[not found] ` <18558.44430.959865.662592-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-07-17 10:38 ` Steve Dickson
2008-07-17 22:50 ` Neil Brown [this message]
2008-07-17 23:15 ` Neil Brown
2008-07-18 0:12 ` Neil Brown
[not found] ` <18559.57353.428342.328105-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-07-18 4:54 ` Chuck Lever
2008-08-28 15:35 ` Steve Dickson
[not found] ` <18559.53893.95829.499988-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-07-19 16:09 ` Chuck Lever
2008-07-20 6:48 ` Neil Brown
[not found] ` <18562.57287.656749.540603-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-07-21 1:28 ` Chuck Lever
2008-07-21 2:49 ` Neil Brown
2008-07-21 2:55 ` Neil Brown
[not found] ` <18563.64191.468427.481673-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-07-21 20:59 ` Chuck Lever
[not found] ` <18563.63821.501053.402741-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-07-21 4:43 ` Chuck Lever
2008-07-21 6:06 ` Neil Brown
[not found] ` <18564.10115.809293.243948-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-07-21 15:32 ` Chuck Lever
[not found] ` <76bd70e30807210832l188bd3adl92762d5856bbaa5e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-07-21 17:40 ` Trond Myklebust
2008-07-21 19:01 ` Chuck Lever
2008-07-21 17:23 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18559.52411.176479.699140@notabene.brown \
--to=neilb@suse.de \
--cc=SteveD@redhat.com \
--cc=chucklever@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox