Re: Thoughts about cache consistency and directories in particular.

[Neil Brown <neilb@suse.de>]

On Friday February 20, trond.myklebust@fys.uio.no wrote:
> On Sat, 2009-02-21 at 06:52 +1100, Neil Brown wrote:
> > On Friday February 20, trond.myklebust@fys.uio.no wrote:
> > > It should work fine. The ctime tracks the mtime in all cases except when
> > > you setacl, setfattr, chown, chgrp, chmod, or touch the directory. Those
> > > should be very rare operations for pretty much any workload...
> > > 
> > 
> > Does that mean you'll take the patch ??
> 
> Not as it stands. You really want to be calling
> nfs_force_lookup_revalidate() instead of invalidating the directory
> contents.

Surely it is 'aswell' rather than 'instead' ??
I need 
   invalid |= NFS_INO_INVALID_DATA;
to flush the readdir cache, and
   nfs_force_lookup_revalidate(inode)
to flush the lookup cache 
??

I'll respin the patches later today.

Thanks,
NeilBrown