public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH]  bug in old-cache handling in mountd.
Date: Thu, 4 Jun 2009 08:45:38 +1000	[thread overview]
Message-ID: <18982.64786.654330.415419@notabene.brown> (raw)
In-Reply-To: message from Steve Dickson on Wednesday June 3

On Wednesday June 3, SteveD@redhat.com wrote:
> 
> 
> Neil Brown wrote:
> > Hi,
> >  there is a bug in the old-cache behaviour of mountd.
> >  Hopefully no-one is using this but you never know....
> > 
> >  The bug was reported to redhat
> >     https://bugzilla.redhat.com/show_bug.cgi?id=164186
> > 
> >  It was fixed incorrectly and never (that I recall) reported
> >  upstream. :-(
> > 
> >  A SLES customer thinks they have hit the same problem, which is why
> >  I'm looking at it.  (They shouldn't really hit it because that
> >  version of sles uses 'new_cache' but maybe nfsdfs was disabled
> >  somehow - don't know yet).
> > 
> >  Anyway, when mountd gets a mount request, it tells the kernel about it
> >  and remembers that it told the kernel so it doesn't have to tell the
> >  kernel again.
> >  It is possible that "exportfs -r" will tell the kernel to forget that
> >  information if the client has since unmounted.
> >  So mountd really needs to tell the kernel even if it thinks the
> >  kernel should already know.
> > 
> >  The following patch does this if the kernel refuses to provide a
> >  valid filehandle.
> > 
> >  Does RHEL3 use old-cache or new-cache ??
> The new cache, if it exists...

That's what I would have thought... which leave me wondering how both
your customer and our customer hit the bug...  I must be missing
something important.

> 
> Committed..

Thanks.

NeilBrown

      reply	other threads:[~2009-06-03 22:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-29  1:49 [PATCH] bug in old-cache handling in mountd Neil Brown
     [not found] ` <18975.16159.264056.854413-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2009-06-03 19:45   ` Steve Dickson
2009-06-03 22:45     ` Neil Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18982.64786.654330.415419@notabene.brown \
    --to=neilb@suse.de \
    --cc=SteveD@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox