Re: [PATCH 01/12] sunrpc/cache: rename queue_loose to cache_dequeue

J. Bruce Fields
2009-08-04T14:05:25Z

On Tue, Aug 04, 2009 at 03:22:38PM +1000, NeilBrown wrote:
> 'loose' was a mis-spelling of 'lose', and even that wasn't a good
> word choice.
> So give this function a more useful name.

OK, others may take me longer to get to, but this is easy enough to
apply now! Done.--b.

>
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
>
> net/sunrpc/cache.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
> index ff0c230..d19c075 100644
> --- a/net/sunrpc/cache.c
> +++ b/net/sunrpc/cache.c
> @@ -101,7 +101,7 @@ struct cache_head *sunrpc_cache_lookup(struct cache_detail *detail,
> EXPORT_SYMBOL_GPL(sunrpc_cache_lookup);
>
>
> -static void queue_loose(struct cache_detail *detail, struct cache_head *ch);
> +static void cache_dequeue(struct cache_detail *detail, struct cache_head *ch);
>
> static int cache_fresh_locked(struct cache_head *head, time_t expiry)
> {
> @@ -117,7 +117,7 @@ static void cache_fresh_unlocked(struct cache_head *head,
> cache_revisit_request(head);
> if (test_and_clear_bit(CACHE_PENDING, &head->flags)) {
> cache_revisit_request(head);
> - queue_loose(detail, head);
> + cache_dequeue(detail, head);
> }
> }
>
> @@ -457,7 +457,7 @@ static int cache_clean(void)
> )
> continue;
> if (test_and_clear_bit(CACHE_PENDING, &ch->flags))
> - queue_loose(current_detail, ch);
> + cache_dequeue(current_detail, ch);
>
> if (atomic_read(&ch->ref.refcount) == 1)
> break;
> @@ -920,7 +920,7 @@ static const struct file_operations cache_file_operations = {
> };
>
>
> -static void queue_loose(struct cache_detail *detail, struct cache_head *ch)
> +static void cache_dequeue(struct cache_detail *detail, struct cache_head *ch)
> {
> struct cache_queue *cq;
> spin_lock(&queue_lock);
>
>